Debian: remove force-cgroups-v1 code #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cirrus CI build successful. Found built image names and IDs:
|
|
Cirrus CI build successful. Found built image names and IDs:
|
|
[Packages are identical to #338] |
edsantiago
force-pushed
the
debian_cgroups_v2
branch
from
52e8fc2
to
9c2d6e8
Compare
|
Well, this is not going to be easy. |
|
Cirrus CI build successful. Found built image names and IDs:
|
edsantiago
force-pushed
the
debian_cgroups_v2
branch
from
9c2d6e8
to
7529bf0
Compare
|
Cirrus CI build successful. Found built image names and IDs:
|
|
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
May 14, 2024
As agreed in Planning meeting of 2024-03-20, Podman 5.x will drop support for cgroups v1 and for runc. Make it so. CI images built in containers/automation_images#338 Signed-off-by: Ed Santiago <santiago@redhat.com>
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
May 15, 2024
As agreed in Planning meeting of 2024-03-20, Podman 5.x will drop support for cgroups v1 and for runc. Make it so. CI images built in containers/automation_images#338 Signed-off-by: Ed Santiago <santiago@redhat.com>
edsantiago
force-pushed
the
debian_cgroups_v2
branch
from
7529bf0
to
b27b1a2
Compare
|
@containers/podman-maintainers looks like our days of testing cgroups v1 are numbered. New debian VMs are bringing in new systemd, which refuses to boot under cgroups v1. See #355 for further details. |
|
I think that's OK now. We don't release to RHEL8 anymore. 9 can switch to CGv1 but it's not the default. 5 officially deprecated CGv1 support. |
|
it's okay, and (per commit message) this was agreed to on March 20 in Planning, but podman tests are going to need some surgery and I've let that slide. Fortunately I have nothing else going on this week[1] so I'll get on that ASAP. [1] joke. not a funny one. |
|
Think of the all the v1/v2 conditionals that we can remove in the tests and eventually the code as well |
edsantiago
force-pushed
the
debian_cgroups_v2
branch
from
b27b1a2
to
3fdfa74
Compare
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
May 28, 2024
As agreed in Planning meeting of 2024-03-20, Podman 5.x will drop support for cgroups v1 and for runc. Make it so. CI images built in containers/automation_images#338 Signed-off-by: Ed Santiago <santiago@redhat.com>
|
Cirrus CI build successful. Found built image names and IDs:
|
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
May 28, 2024
As agreed in Planning meeting of 2024-03-20, Podman 5.x will drop support for cgroups v1 and for runc. Make it so. CI images built in containers/automation_images#338 Signed-off-by: Ed Santiago <santiago@redhat.com>
edsantiago
added a commit
to edsantiago/buildah
that referenced
this pull request
May 29, 2024
Per consent in 2024-03-20 Planning, remove support for cgroups v1. And, per discovery on 2024-05-28, systemd 256 no longer even boots on a cgroups v1 system. This commit switches to VMs built in: containers/automation_images#338 ...in which Debian is now cgroups v2 with crun. Signed-off-by: Ed Santiago <santiago@redhat.com>
edsantiago
added a commit
to edsantiago/buildah
that referenced
this pull request
May 29, 2024
Per consent in 2024-03-20 Planning, remove support for cgroups v1. And, per discovery on 2024-05-28, systemd 256 no longer even boots on a cgroups v1 system. This commit switches to VMs built in: containers/automation_images#338 ...in which Debian is now cgroups v2 with crun. Requires disabling two conformance tests which fail when run against docker 26.1; see containers#5526 for context on those. And, latest git on f40 refuses to serve non-root files when run as root ("dubious ownership"); so, in start_git_daemon(), chown the extracted files. Signed-off-by: Ed Santiago <santiago@redhat.com>
|
|
sigh..... |
Per discussion in 2024-03-20 Planning meeting, we will no longer be testing runc in CI. And cgroups V1 is dead too. Signed-off-by: Ed Santiago <santiago@redhat.com>
It has been retired in Rawhide, and it's unclear whether we need it at all. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
plocate is the default locate implementation in Fedora. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
edsantiago
force-pushed
the
debian_cgroups_v2
branch
from
3fdfa74
to
564b76c
Compare
cevich
approved these changes
May 29, 2024
> panic: encoding alphabet includes duplicate symbols Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
Cirrus CI build successful. Found built image names and IDs:
|
|
edsantiago
added a commit
to edsantiago/buildah
that referenced
this pull request
May 29, 2024
Per consent in 2024-03-20 Planning, remove support for cgroups v1. And, per discovery on 2024-05-28, systemd 256 no longer even boots on a cgroups v1 system. This commit switches to VMs built in: containers/automation_images#338 ...in which Debian is now cgroups v2 with crun. Requires disabling two conformance tests which fail when run against docker 26.1; see containers#5526 for context on those. Also requires disabling two bats tests on debian because something changed there in ulimits. I'll look into them later but right now this gives us breathing space. And, latest git on f40 refuses to serve non-root files when run as root ("dubious ownership"); so, in start_git_daemon(), chown the extracted files. Signed-off-by: Ed Santiago <santiago@redhat.com>
edsantiago
added a commit
to edsantiago/buildah
that referenced
this pull request
May 29, 2024
Per consent in 2024-03-20 Planning, remove support for cgroups v1. And, per discovery on 2024-05-28, systemd 256 no longer even boots on a cgroups v1 system. This commit switches to VMs built in: containers/automation_images#338 ...in which Debian is now cgroups v2 with crun. Requires disabling two conformance tests which fail when run against docker 26.1; see containers#5526 for context on those. Also requires disabling two bats tests on debian because something changed there in ulimits. I'll look into them later but right now this gives us breathing space. And, latest git on f40 refuses to serve non-root files when run as root ("dubious ownership"); so, in start_git_daemon(), chown the extracted files. Signed-off-by: Ed Santiago <santiago@redhat.com>
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
May 29, 2024
Another new-VM import from containers/automation_images#338 ...because the usual conflict dealio in that repo. This should mostly be a NOP. All the major work was done in containers#22706. Signed-off-by: Ed Santiago <santiago@redhat.com>
edsantiago
added a commit
to edsantiago/skopeo
that referenced
this pull request
May 29, 2024
Changes: - fix from @mtrmac for go-1.22 panic ("alphabet, duplicate symbols") - debian is now cgroupsv2 + crun (does not affect skopeo) - many other Red Queen fixes Built in: containers/automation_images#338 Signed-off-by: Ed Santiago <santiago@redhat.com>
cevich
approved these changes
May 29, 2024
There was a problem hiding this comment.
LGTM, thanks for seeing this through. In my mind at least, there's a bunch of comments and code in podman CI that (when using these images) will confusingly suggest CGv1 is in use. Are there any "cgroupsv1" cleanup/followup issues or cards that need creating?
|
Thank you. Yes, there will be a ton of cleanup needed to remove special-case conditionals. I've chosen not to tackle that yet. |
That's fine, I or someone else may be able to help with this. I just wanted to know if you had already opened an issue/card or set a personal reminder. I'll go ahead and file a Jira card. |
This was referenced Jun 6, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in 2024-03-20 Planning meeting, we will no
longer be testing runc in CI. And cgroups V1 is dead too.
Signed-off-by: Ed Santiago santiago@redhat.com