Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make buildah manifest push --all true by default #5755

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

k9withabone
Copy link
Member

What type of PR is this?

/kind api-change

/kind bug

/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

Changed the --all option of buildah manifest push to be true by default. This matches the behavior of the equivalent Podman option (podman manifest push --all), making it easier to switch between Podman and Buildah.

Updated buildah-manifest-push(1) docs to reflect this change.

How to verify it

Use buildah manifest push --help, see that at the end of the line for the --all it says (default true).

Which issue(s) this PR fixes:

Fixes #5547

Special notes for your reviewer:

Does this PR introduce a user-facing change?

`buildah manifest push --all` is now true by default to match Podman.

Changed the `--all` option of `buildah manifest push` to be true by
default. This matches the behavior of the equivalent Podman option
(`podman manifest push --all`), making it easier to switch between
Podman and Buildah.

Updated buildah.manifest.push.1 docs to reflect this change.

Added test "manifest-push-all-default-true" to `tests/lists.bats`.

Closes: containers#5547
Signed-off-by: Paul Nettleton <k9@k9withabone.dev>
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 25, 2024
@rhatdan
Copy link
Member

rhatdan commented Sep 26, 2024

Could you Fix the man page and add a tests.

Test could be the equivalent of:

buildah manifest push --help | grep all.*true

@k9withabone
Copy link
Member Author

Added test "manifest-push-all-default-true" to tests/lists.bats.

What's wrong with the man page?

@rhatdan
Copy link
Member

rhatdan commented Sep 28, 2024

Add information about the default being true. Booleans without default in man pages are assumed False.

@k9withabone
Copy link
Member Author

Add information about the default being true.

Already done. It is the same as the Podman man page now.

@rhatdan
Copy link
Member

rhatdan commented Sep 29, 2024

LGTM
@nalind @flouthoc @giuseppe @mheon PTAL

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, k9withabone

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 3, 2024
@rhatdan
Copy link
Member

rhatdan commented Oct 3, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit bd0de14 into containers:main Oct 3, 2024
32 checks passed
@k9withabone k9withabone deleted the manifest-push-all branch October 4, 2024 00:12
@nalind nalind mentioned this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/bug Categorizes issue or PR as related to a bug. lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants