Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit and tidy OWNERS #5770

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Conversation

baude
Copy link
Member

@baude baude commented Oct 4, 2024

Clean ups on reviewers and approvers for the OWNERS file. Removed duplications of reviewers (from approvers) and added Jan.

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@nalind
Copy link
Member

nalind commented Oct 4, 2024

Looks like the bot mistakenly added something back to go.mod when it merged #5755. I guess you can either go mod tidy in a separate commit, or wait for another dependency update along the lines of #5760 to be merged and rebase on top of it.

Clean ups on reviewers and approvers for the OWNERS file. Removed
duplications of reviewers (from approvers) and added Jan.

Signed-off-by: Brent Baude <bbaude@redhat.com>
@baude baude added the No New Tests Allow PR to proceed without adding regression tests label Oct 4, 2024
@rhatdan
Copy link
Member

rhatdan commented Oct 6, 2024

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1450bf8 into containers:main Oct 6, 2024
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/other lgtm No New Tests Allow PR to proceed without adding regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants