Netavark plugin support #1388
Merged
Netavark plugin support #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold until the netavark PR is ready to go |
Luap99
force-pushed
the
netavark-plugin
branch
2 times, most recently
from
0d67a5e to
4ac6c6b
Compare
|
LGTM |
|
I am unqualified to review due to my lack of knowledge on netavark. @flouthoc can you take a look? |
flouthoc
reviewed
Apr 4, 2023
flouthoc
approved these changes
Apr 4, 2023
|
/lgtm |
|
Please review containers/netavark#509 |
Users can now suplly custom network drivers which will execute the netavark plugin to create the network. Netavark will execute the pluign to setup/teardown the netns. see containers/netavark#509 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Add config field to specify the location for the netavark plugins. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Add a custom plugin that can be used in the netavark unit tests to check if the integration works as expected. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
The the plugin integration with the testplugin. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Netavark needs to get the actual list of directories from podman because users can set them in contianers.conf. Note that this change requires a netavark with containers/netavark#509 To allow better backwards compat we only pass the new argument when we need. Also added the missing ipvlan driver to the supported driver list. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
Rebased and repushed to add missing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see individual commits
and containers/netavark#509