add netavark plugin support #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @Luap99, happy new year. Hows the progress on this? |
|
@b-m-f Sorry I have a lot going on at the moment, I try to get back to this soon. I will talk with the team to see how we can proceed with your PR. |
Luap99
force-pushed
the
plugin
branch
2 times, most recently
from
8cdea82 to
d548fac
Compare
|
Can the WIP be dropped? |
mheon
reviewed
Jan 18, 2023
I want to make sure this is not merged yet, I still need to test with c/common and podman. Also if we plan to do another release this week this should wait for the next one. |
|
@Luap99 should I start rebasing thr WireGuard changes onto this branch? Im also wondering what to do about my PRs in the podman and containers/common repos. |
Luap99
added a commit
to Luap99/common
that referenced
this pull request
Mar 30, 2023
Users can now suplly custom network drivers which will execute the netavark plugin to create the network. Netavark will execute the pluign to setup/teardown the netns. see containers/netavark#509 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
force-pushed
the
plugin
branch
2 times, most recently
from
a33d6d6 to
f23b1d1
Compare
Luap99
added a commit
to Luap99/common
that referenced
this pull request
Mar 30, 2023
Netavark needs to get the actual list of directories from podman because users can set them in contianers.conf. Note that this change requires a netavark with containers/netavark#509 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
added a commit
to Luap99/common
that referenced
this pull request
Apr 3, 2023
Users can now suplly custom network drivers which will execute the netavark plugin to create the network. Netavark will execute the pluign to setup/teardown the netns. see containers/netavark#509 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
added a commit
to Luap99/common
that referenced
this pull request
Apr 3, 2023
Netavark needs to get the actual list of directories from podman because users can set them in contianers.conf. Note that this change requires a netavark with containers/netavark#509 To allow better backwards compat we only pass the new argument when we need. Also added the missing ipvlan driver to the supported driver list. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Add a function to move an interface in a new netns. This will be needed by the example plugin which I will add in the folloing commits. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Add a function to return the addresses for all interfaces in the namespace. This will be used by the example plugin. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Add a rust plugin trait which can be used to create plugins without any extra boilerplate code. See the following commits for an example of how to use this. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
baude
reviewed
Apr 4, 2023
|
this is great work ... LGTM thanks @Luap99 |
Create a simple netavark plugin which is used to move a host interface into the contianer interface. Use the examples make target to compile it. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Make a plugin which always errors to test failure paths. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This contains the core netavark logic to actually execute custom plugins. This adds a new --plugin-directory option which can be set multiple times to give a list of directories that will be searched for the plugin. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Plugins are allowed to log on stderr, add a small pluign to test it. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
added a commit
to Luap99/common
that referenced
this pull request
Apr 4, 2023
Users can now suplly custom network drivers which will execute the netavark plugin to create the network. Netavark will execute the pluign to setup/teardown the netns. see containers/netavark#509 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
added a commit
to Luap99/common
that referenced
this pull request
Apr 4, 2023
Netavark needs to get the actual list of directories from podman because users can set them in contianers.conf. Note that this change requires a netavark with containers/netavark#509 To allow better backwards compat we only pass the new argument when we need. Also added the missing ipvlan driver to the supported driver list. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
/lgtm Nice work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a plugin system for netavark,
check the plugin-API.md file for a description.
see commits for details