Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-ci] RPM: `zstd:chunked on fedora > 40 and rhel > 10 #2048

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

cgwalters
Copy link
Contributor

Signed-off-by: Lokesh Mandvekar lsm5@redhat.com
(cherry picked from commit d3ca62d)

xref #2026 (comment)

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
(cherry picked from commit d3ca62d)
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@lsm5 PTAL

Note I don't think we have any plans to tag a new upstream release here currently so I suggest someone should push the fix to the fedora dist-git and not wait for a upstream release on this branch.

Copy link
Contributor

openshift-ci bot commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters
Copy link
Contributor Author

Note I don't think we have any plans to tag a new upstream release here currently so I suggest someone should push the fix to the fedora dist-git and not wait for a upstream release on this branch.

OK, done in
https://src.fedoraproject.org/rpms/containers-common/c/85f169278be0f0683c0c9c8146a0af11cef4689e?branch=f40 and https://koji.fedoraproject.org/koji/taskinfo?taskID=118888420

@travier
Copy link
Member

travier commented Jun 11, 2024

Unfortunately, if my understanding is correct, cherry-picking the patch won't fix the issue

@rhatdan
Copy link
Member

rhatdan commented Jun 11, 2024

/lgtm

@cgwalters
Copy link
Contributor Author

Unfortunately, if my understanding is correct, cherry-picking the patch won't fix the issue

I double checked after the RPM build that it had the correct contents in its containers.conf.

I also now triple checked via installing https://bodhi.fedoraproject.org/updates/FEDORA-2024-ebe5c816a1
and verifying that before that, podman push would add a zstd layer, and after it doesn't. Please give karma there too!

@openshift-merge-bot openshift-merge-bot bot merged commit d89fcc4 into containers:v0.59 Jun 11, 2024
10 checks passed
@cgwalters
Copy link
Contributor Author

Also, for those interested: containers/buildah#5586

@travier
Copy link
Member

travier commented Jun 12, 2024

I double checked after the RPM build that it had the correct contents in its containers.conf.

I also now triple checked via installing bodhi.fedoraproject.org/updates/FEDORA-2024-ebe5c816a1 and verifying that before that, podman push would add a zstd layer, and after it doesn't. Please give karma there too!

Great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants