balloons: implement groupBy option #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askervin
force-pushed
the
5Tk_balloons_groupby_stacked
branch
2 times, most recently
from
d80d51e
to
66d7c54
Compare
klihub
changed the title
|
@askervin Can you run locally a That would get us rid of the failed minimal verification. |
askervin
force-pushed
the
5Tk_balloons_groupby_stacked
branch
from
66d7c54
to
ea01fdb
Compare
Expose evaluation of (potentially joint) pod and container key references using the newly added EvalRef() Evaluable interface. This allows one to evaluate the values of key references which originally were only used in expressions without having to put an expression around such references. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Implement Expand() which scans an input string, substituting
plain $keys and/or well-formed ${keys} in the output with the
referenced values. Add corresponding convenience wrappers to
pods and containers.
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
groupBy groups containers into same balloon instances if their groupBy
expressions evaluate to the same group. Expressions are strings where
key references like ${pod/labels/mylabel} will be substituted with
corresponding values.
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
askervin
force-pushed
the
5Tk_balloons_groupby_stacked
branch
from
ea01fdb
to
38d9f93
Compare
klihub
previously approved these changes
Mar 14, 2024
klihub
dismissed
their stale review
This looks otherwise fine, but looks like it requires a manual rebase due to conflicts. @askervin If you rebase it, I can LGTM it.
klihub
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
groupBy enables grouping containers into balloon instances.
Stacked on top of PR #277.