Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes: update k8s repo location, use latest releases in e2e tests. #279

Merged
merged 1 commit into from
Mar 13, 2024
Merged

fixes: update k8s repo location, use latest releases in e2e tests. #279

merged 1 commit into from
Mar 13, 2024

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Mar 5, 2024 •
edited
Loading

Update e2e test VM provisioning to use the new pkgs.k8s.io repositories. Also autodetect and use the latest Kubernetes, containerd and CRI-O versions, unless this is overridden by the user.

@klihub
Copy link
Collaborator Author

klihub commented Mar 5, 2024

@askervin If you have time, you could give this one a try with #278.

@askervin
Copy link
Collaborator

askervin commented Mar 5, 2024

You were on it, too...

I think this patch wins #280 by fixing the issue on deb packages, too. But if possible, I'd still like the e2e framework to automatically pick the latest k8s version unless user forces one.

If you prefer having the version number in the playbook more than run(_tests).sh env var, let's have it there. (Maybe move to vars: section in the playbook.) If you are ok to have it as env var, possibly with autodetect-latest-hack in #280, I'll update that patch to fix deb package repo as you did here.

@klihub
Copy link
Collaborator Author

klihub commented Mar 6, 2024

You were on it, too...

I think this patch wins #280 by fixing the issue on deb packages, too. But if possible, I'd still like the e2e framework to automatically pick the latest k8s version unless user forces one.

If you prefer having the version number in the playbook more than run(_tests).sh env var, let's have it there. (Maybe move to vars: section in the playbook.) If you are ok to have it as env var, possibly with autodetect-latest-hack in #280, I'll update that patch to fix deb package repo as you did here.

@askervin I added overridable autodetection of latest K8s release. It successfully installed 1.29.2 in my balloons tests.

@klihub klihub marked this pull request as ready for review March 6, 2024 08:56
askervin
askervin previously approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @klihub!

@askervin askervin mentioned this pull request Mar 6, 2024
Closed
@klihub klihub force-pushed the fixes/migrated-k8s-repos branch 3 times, most recently from 1834244 to 707db70 Compare March 6, 2024 09:43
@klihub klihub requested a review from askervin March 6, 2024 10:49
@klihub klihub changed the title fixes: use new/migrated k8s repos in e2e tests. fixes: update k8s repo location, use latest releases in e2e tests. Mar 6, 2024
@klihub klihub dismissed askervin’s stale review March 6, 2024 11:18

@askervin Updated to autodetect both latest K8s and runtime version. PTAL.

askervin
askervin approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works great (running groupBy tests on Fedora now)

fmuyassarov
fmuyassarov reviewed Mar 12, 2024
View reviewed changes
test/e2e/run.sh Outdated Show resolved Hide resolved
@klihub
test/e2e: switch to using pkgs.k8s.io repos.
b27c140 
Switch provisioning of both fedora and ubuntu-based e2e test VMs
to the pkgs.k8s.io repositories. Also try autodetecting and using
the latest available K8s, containerd and CRI-O releases/versions,
unless this is overridden by the user.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub klihub requested a review from fmuyassarov March 12, 2024 22:27
@fmuyassarov fmuyassarov merged commit 0165aa8 into containers:main Mar 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askervin askervin askervin approved these changes

@fmuyassarov fmuyassarov fmuyassarov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klihub @askervin @fmuyassarov