[RFC] Fix namespaced paths in Contao DataCollector #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Contao DataCollector used an outdated method for referencing templates which seen to have been remove recently. Update to the modern @-prefixed way of referencing templates. > In the past, Symfony used a different syntax to refer to templates. This format, which uses colons (:) to separate each template path section, is less consistent and has worse performance than the Twig syntax. (https://symfony.com/doc/3.4/templating/namespaced_paths.html) > [...] but you must prefix the @ character when using it in templates (that's how Twig can differentiate namespaces from regular paths). (https://symfony.com/doc/current/templating/namespaced_paths.html)
|
Thank you @sheeep. |
leofeyer
added a commit
that referenced
this pull request
Jun 9, 2020
Description ----------- | Q | A | -----------------| --- | Fixed issues | Fixes #1379 | Docs PR or issue | - Commits ------- 5f203303 Hide the crawler in maintenance mode aa7e9a75 Show a hint in the back end why crawler is unavailable ecea5974 Resolve the conflict and change the error message to an info message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Contao DataCollector used an outdated method for referencing templates which
seen to have been remove recently. Update to the modern @-prefixed way of referencing
templates.
Fixes the following error (occures when opening the debugger, or even just show the debug toolbar).
There is one open question (thus tagged as RFC). It does seem to work in the managed edition. Any idea why?