Use the modern @-notation when referencing twig templates for Menu #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @sheeep. |
leofeyer
pushed a commit
that referenced
this pull request
Jun 29, 2020
Description ----------- If any settings of the `localconfig` are defined by the `contao.localconfig` parameter the settings made in the Contao backend are ignored. However it's possible to edit the settings in the backend, but the changes are not visible after save+reload. This PR disables all settings which are defined by parameter so that you easily see that these settings are overriden by `contao.localconfig`. Furthermore the `important.svg` icon is added to the label to explain why the setting is disabled. This might be helpful if you work with different administrators (where some don't have access to the code). I decided not to remove the fields, so the values are visible and people won't get confused about the missing configurations. Commits ------- de34649b Disable settings in the backend which are defined by the contao.localconfig parameter e2e43650 Add unit tests f1d7e1f3 Use wildcard for missing method to silence undefined method error 3f31d9ed Remove ServiceAnnotationInterface listener is configured using listener.yml 3eeed85a Rename parameter based to bundle configuration e13836c4 Always set contao.localconfig parameter 32633e12 Improve translation Co-Authored-By: Hannes <github@gmx.net> ef2cf67f Annotate `Adapter` with phpstan `@mixin` Revert and adapt ignoreErrors configuration for `missingMethod` 5a856b6d Fix code style 9d91f0dd Improve ignore error configuration 566f4dc3 Fix yaml idention 85d6ebf1 Yet another yaml style fix f33879f2 Merge branch 'master' into feature/disable-settings e8c4d60d Merge branch 'master' into feature/disable-settings 43e9d1df Drop redundant `template` and `mixin` annotation 59e4b180 Use `ServiceAnnotationInterface` instead of explicit configured tags b9d81487 Fix a few minor issues 95741bc9 Merge branch 'master' into feature/disable-settings efe0a6e6 Use the info icon instead of the error icon cde293e2 Re-add the assertInstanceOf() check 7ba2c65f Rename the listener as discussed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details available in this PR.