[RTM] PHP Toolbox support #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. ✌️ |
|
Is this something we want to add to the core, event though it's IDE specific?
If so, let's think of other places we could use autocomplete. And no, DCA probably wont work 😂
|
leofeyer
changed the title
|
I just thought about this again, and I can't come up with additional ideas. I think this can be merged as-is, and we'll simply extend when we find something. |
aschempp
changed the title
leofeyer
requested changes
Jan 13, 2017
| "provider":"contao_framework_classes", | ||
| "language":"php", | ||
| "signature":[ | ||
| "Contao\\CoreBundle\\Framework\\ContaoFrameworkInterface:getAdapter" |
There was a problem hiding this comment.
I understand that you have added this here again (see line 12), because there are two different providers. How exactly do they differ?
There was a problem hiding this comment.
The provider is different. The first one allows subclasses of Contao\System, but some are not (like System itself and Config, maybe there's even more).
| }, | ||
| { | ||
| "name": "contao_languagefiles", | ||
| "lookup_strings": ["default", "explain"] |
There was a problem hiding this comment.
Should we add the other core-bundle language files here?
There was a problem hiding this comment.
It would not harm, I was just too lazy in the draft :-)
| { | ||
| "lookup_string": "return", | ||
| "type_text": "Model|Collection|Array" | ||
| } |
There was a problem hiding this comment.
Here are the options I have found:
-
table -
column -
value -
limit -
offset -
return -
order(probably what you mean bysorting)
leofeyer
approved these changes
Jan 19, 2017
agoat
pushed a commit
to agoat/contao-core-bundle
that referenced
this pull request
Apr 10, 2017
* Make Symfony 3.2 the minimum requirement (see contao#630). * Set the encryption key from the kernel secret by default (see contao#660). * Stop using the deprecated QuestionHelper::setInputStream() method. * Update Dropzone to version 4. * Prefer the caret operator over the tilde operator in the composer.json file. * Add the contao.root_dir parameter (see contao#662). * Update the change log. * Stop using the contao-components/all meta package. * Update the README.md file. * Deprecate the contao:version command (see contao#668). * Update the installation path. * Auto-select the active page in the quick navigation/link module (see contao/core#8587). * Look up the form class and allow to choose the type (see contao/core#8527). * Add PHP Toolbox support (see contao#565). * Remove the arrow brackets in the book navigation template (see contao/core#8607). * Add a bottom padding to the buttons layer. * Add the contao.web_dir parameter (see contao/installation-bundle#40). * Fix the tests. * Match security firewall based on request scope (see contao#677). * Fix an issue found by Scrutinizer. * Use the contao.web_dir parameter in the Combiner (see contao#679). * Fix the tests. * Add stripRootDir() method to System class (see contao#683). * Add the contao.image.target_dir parameter (see contao#684). * The ContaoCoreExtension::overwriteImageTargetDir() is not deprecated. * Support custom backend routes (see contao#512). * Use the scope matcher instead of checking the request attribute (see contao#688). * Replace every occurrence of $contaoFramework with $framework. * Fix an issue found by Scrutinizer. * Fix deprecations in unit tests (see contao#687). * Added a DBAL field type for UUIDs (see contao#415). * Support importing form field options from a CSV field (see contao#444). * Fix the coding style and the unit tests. * Add the Doctrine field type in the config.yml file. doctrine: dbal: types: binary_string: class: "Contao\\CoreBundle\\Doctrine\\DBAL\\Types\\BinaryStringType" commented: true * Add a basic unit test for the BackendCsvImportController class. * Update the change log. * Fix rebuilding the search index (see contao#689). * Also handle „no origin“ and „empty origin“ in the CORS provider. * Remove an unused use statement. * Remove the security.yml file and update the README.md file. * Improve the e-mail extraction in the text element (thanks to Martin Auswöger). * Rename the Test namespace to Tests. * Update the composer.json file. * Update the .php_cs file. * Raise the minimum PHP version to 5.6 (see contao#701). * Support using objects in callback arrays (see contao#699). * Use try-finally blocks to close all output buffers when downloading a file (see contao#714). * Fix the coding style. * Only prefix an all numeric alias when standardizing (see contao#707). * Adjust the test namespaces. * Allow to manually pass a value to any widget (see contao#674). * Add a change log entry and fix the tests. * Disable the picker buttons if the main window does not show a picker. * Use the file manager instead of the file picker. * Use the site structure instead of the page picker. * Always show the selected nodes. * Add the menu builder.
leofeyer
pushed a commit
that referenced
this pull request
Jul 9, 2019
Description ----------- There is only one difference now that I can think of: If you open the login page, and then manually reload, the previous page will be gone… Commits ------- fe783229 Do not use session to store the last visited page 0c914d12 Simplify if condition 5f85fc94 No need to check hasPreviousSession, it will be killed again anyway 88f6a238 Fix the coding style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHP Toolbox plugin adds customizable autocomplete additions to PhpStorm. Here's a simple draft for Contao
core-bundle.ContaoFrameworkInterface::getAdapter()These are just examples and if we come up with more ideas it's highly extendable 😎