Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTM] Make Symfony 3.2 the minimum requirement. #630

Merged
merged 3 commits into from
Dec 29, 2016
Merged

[RTM] Make Symfony 3.2 the minimum requirement. #630

merged 3 commits into from
Dec 29, 2016

Conversation

leofeyer
Copy link
Member

This PR makes Symfony 3.1 the minimum requirement and removes the container scope usage.

@leofeyer leofeyer changed the title Make Symfony 3.1 the minimum requirement. [RTM] Make Symfony 3.1 the minimum requirement. Nov 21, 2016
@leofeyer
Copy link
Member Author

@contao/developers Please review.

@leofeyer leofeyer added this to the 4.3.0 milestone Nov 21, 2016
discordier
discordier approved these changes Nov 21, 2016
View reviewed changes
Copy link
Contributor

@discordier discordier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections from my side.

@aschempp
Copy link
Member

Can you write down here for the public why we are increasing the requirements?

@ausi ausi mentioned this pull request Nov 21, 2016
Closed
2 tasks
Toflar
Toflar approved these changes Nov 21, 2016
View reviewed changes
Copy link
Member

@Toflar Toflar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raising the constraint of a dependency is always allowed. Even though it's a major version. The main question is whether the public API of our own bundle/library remains the same which is the case here. Of course, you should not just raise the minimum requirements if there is no real use case but I think we have a lot of reasons for the Contao Core bundle here:

  1. We can reduce dependency hell.
  2. We can get rid of a hell lot of BC code we were never using and which was present in the SF code base and might have confused people.
  3. We can benefit from the incredible important new SF features, especially the PSR-6 cache component because we now have a common interface for cache implementations which is crucial to me. Otherwise we'll implement our own stuff for different areas and end up having several interfaces which we'll have to maintain for the whole 4.* branch

Side note: We should all be more aggressive in bumping minimum versions in general. Again, if it's not needed, don't do it. But if it makes your life easier (and it definitely does in this case) then go for it. I found Jordi's blog post a good read.

@aschempp
Copy link
Member

yeah, that's what I don't understand…

  1. not a valid reason, because as you said if it's not needed, don't do it
  2. As you can see in the pull request, there is almost no BC code
  3. We definitely should benefit from these features, but we should not raise minimum requirements before we actually use them …

@Toflar
Copy link
Member

Toflar commented Nov 21, 2016

  1. You don't read what I write. "if it makes your life easier (and it definitely does in this case) then go for it.".
  2. You don't read what I write. "which was present in the SF code base and might have confused people".
  3. We do use them. This PR here is the foundation for [RFC] Use a cache for image dimensions #626 which would be even better if it used cache pools introduced in 3.1.

BTW:
Raise minimum req: 4
Stay where we are: 1

@aschempp
Copy link
Member

Yeah, I just don't understand why we discussed this at the user meeting and agreed to not raise it until we actually need/use one of the new features…

@leofeyer leofeyer modified the milestones: 4.4.0, 4.3.0 Nov 23, 2016
@leofeyer leofeyer force-pushed the release/4.3.0 branch 2 times, most recently from 6123499 to ba5c552 Compare November 24, 2016 10:51
@leofeyer leofeyer self-assigned this Nov 25, 2016
@leofeyer leofeyer closed this Nov 25, 2016
@aschempp
Copy link
Member

This should be rebased on develop and reopened.

@leofeyer leofeyer changed the base branch from release/4.3.0 to develop November 28, 2016 12:20
@leofeyer leofeyer reopened this Nov 28, 2016
@leofeyer leofeyer changed the title [RTM] Make Symfony 3.1 the minimum requirement. [RTM] Make Symfony 3.2 the minimum requirement. Dec 1, 2016
@leofeyer
Copy link
Member Author

leofeyer commented Dec 1, 2016

I have raised the minimum Symfony version to 3.2 now.

@leofeyer leofeyer merged commit 82a8ecb into develop Dec 29, 2016
@leofeyer leofeyer deleted the drop-sf2-support branch December 29, 2016 11:10
leofeyer added a commit to contao/calendar-bundle that referenced this pull request Jan 10, 2017
@leofeyer
Make Symfony 3.2 the minimum requirement (see contao/core-bundle#630).
7bd6ecf
leofeyer added a commit to contao/comments-bundle that referenced this pull request Jan 10, 2017
@leofeyer
Make Symfony 3.2 the minimum requirement (see contao/core-bundle#630).
8235214
leofeyer added a commit to contao/faq-bundle that referenced this pull request Jan 10, 2017
@leofeyer
Make Symfony 3.2 the minimum requirement (see contao/core-bundle#630).
b76d116
leofeyer added a commit to contao/installation-bundle that referenced this pull request Jan 10, 2017
@leofeyer
Make Symfony 3.2 the minimum requirement (see contao/core-bundle#630).
8587c15
leofeyer added a commit to contao/listing-bundle that referenced this pull request Jan 10, 2017
@leofeyer
Make Symfony 3.2 the minimum requirement (see contao/core-bundle#630).
fbd9d9f
leofeyer added a commit to contao/news-bundle that referenced this pull request Jan 10, 2017
@leofeyer
Make Symfony 3.2 the minimum requirement (see contao/core-bundle#630).
254a535
leofeyer added a commit to contao/newsletter-bundle that referenced this pull request Jan 10, 2017
@leofeyer
Make Symfony 3.2 the minimum requirement (see contao/core-bundle#630).
6c88e1c
leofeyer added a commit to contao/standard-edition that referenced this pull request Jan 10, 2017
@leofeyer
Make Symfony 3.2 the minimum requirement (see contao/core-bundle#630).
2d06e93
leofeyer added a commit to contao/image that referenced this pull request Jan 10, 2017
@leofeyer
Make Symfony 3.2 the minimum requirement (see contao/core-bundle#630).
e7ef947
leofeyer added a commit to contao/imagine-svg that referenced this pull request Jan 10, 2017
@leofeyer
Make Symfony 3.2 the minimum requirement (see contao/core-bundle#630).
31680bc
This was referenced Jan 10, 2017
Closed
Closed
leofeyer added a commit to contao/standard-edition that referenced this pull request Mar 22, 2017
@leofeyer
Make Symfony 3.2 the minimum requirement (see contao/core-bundle#630).
8271f9c
agoat pushed a commit to agoat/contao-core-bundle that referenced this pull request Apr 10, 2017
Feature/dca picker (#46)
2e9b59a 
* Make Symfony 3.2 the minimum requirement (see contao#630).

* Set the encryption key from the kernel secret by default (see contao#660).

* Stop using the deprecated QuestionHelper::setInputStream() method.

* Update Dropzone to version 4.

* Prefer the caret operator over the tilde operator in the composer.json file.

* Add the contao.root_dir parameter (see contao#662).

* Update the change log.

* Stop using the contao-components/all meta package.

* Update the README.md file.

* Deprecate the contao:version command (see contao#668).

* Update the installation path.

* Auto-select the active page in the quick navigation/link module (see contao/core#8587).

* Look up the form class and allow to choose the type (see contao/core#8527).

* Add PHP Toolbox support (see contao#565).

* Remove the arrow brackets in the book navigation template (see contao/core#8607).

* Add a bottom padding to the buttons layer.

* Add the contao.web_dir parameter (see contao/installation-bundle#40).

* Fix the tests.

* Match security firewall based on request scope (see contao#677).

* Fix an issue found by Scrutinizer.

* Use the contao.web_dir parameter in the Combiner (see contao#679).

* Fix the tests.

* Add stripRootDir() method to System class (see contao#683).

* Add the contao.image.target_dir parameter (see contao#684).

* The ContaoCoreExtension::overwriteImageTargetDir() is not deprecated.

* Support custom backend routes (see contao#512).

* Use the scope matcher instead of checking the request attribute (see contao#688).

* Replace every occurrence of $contaoFramework with $framework.

* Fix an issue found by Scrutinizer.

* Fix deprecations in unit tests (see contao#687).

* Added a DBAL field type for UUIDs (see contao#415).

* Support importing form field options from a CSV field (see contao#444).

* Fix the coding style and the unit tests.

* Add the Doctrine field type in the config.yml file.

doctrine:
    dbal:
        types:
            binary_string:
                class: "Contao\\CoreBundle\\Doctrine\\DBAL\\Types\\BinaryStringType"
                commented: true

* Add a basic unit test for the BackendCsvImportController class.

* Update the change log.

* Fix rebuilding the search index (see contao#689).

* Also handle „no origin“ and „empty origin“ in the CORS provider.

* Remove an unused use statement.

* Remove the security.yml file and update the README.md file.

* Improve the e-mail extraction in the text element (thanks to Martin Auswöger).

* Rename the Test namespace to Tests.

* Update the composer.json file.

* Update the .php_cs file.

* Raise the minimum PHP version to 5.6 (see contao#701).

* Support using objects in callback arrays (see contao#699).

* Use try-finally blocks to close all output buffers when downloading a file (see contao#714).

* Fix the coding style.

* Only prefix an all numeric alias when standardizing (see contao#707).

* Adjust the test namespaces.

* Allow to manually pass a value to any widget (see contao#674).

* Add a change log entry and fix the tests.

* Disable the picker buttons if the main window does not show a picker.

* Use the file manager instead of the file picker.

* Use the site structure instead of the page picker.

* Always show the selected nodes.

* Add the menu builder.
@agoat agoat mentioned this pull request Apr 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@discordier discordier discordier approved these changes

@bytehead bytehead bytehead approved these changes

@Toflar Toflar Toflar approved these changes

@ausi ausi ausi approved these changes

Assignees

@leofeyer leofeyer

Labels
feature
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@leofeyer @aschempp @Toflar @ausi @bytehead @discordier