HMS-5268: Template detail page - minor ux changes #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swadeley
reviewed
Jan 15, 2025
| @@ -74,7 +74,7 @@ export default function TemplateRepositoriesTable({ | |||
| }, [snapshotList.length]); | |||
|
|
|||
| const columnHeaders = [ | |||
| { name: 'Repository Name' }, | |||
| { name: 'Repository' }, | |||
There was a problem hiding this comment.
That should be "Name" I think. Check the Jira again.
There was a problem hiding this comment.
Lol i think i got lost in code
Right this needs to be "Name"!!
marusak
reviewed
Jan 15, 2025
src/Pages/Templates/TemplateDetails/components/Tables/TemplateRepositoriesTable.tsx
Outdated
Show resolved
Hide resolved
swadeley
reviewed
Jan 16, 2025
| @@ -74,7 +74,7 @@ export default function TemplateRepositoriesTable({ | |||
| }, [snapshotList.length]); | |||
|
|
|||
| const columnHeaders = [ | |||
| { name: 'Repository Name' }, | |||
| { name: 'Name' }, | |||
| { name: 'Snapshot Date', width: 20 }, | |||
There was a problem hiding this comment.
Suggested change
| { name: 'Snapshot Date', width: 20 }, | |
| { name: 'Snapshot date', width: 20 }, |
In associated Jira, red is used to highlight what is wanted.
EDIT: Maybe it was just sentence case that was asked for, i.e. 'Snapshot date'. I'll ask in Jira for confirmation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing steps