Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMS-5268: Template detail page - minor ux changes #411

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

HMS-5268: Template detail page - minor ux changes #411

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f326ecc
column header name fix
mayurilahane Jan 15, 2025
61590e3
fixed import issue and small nitpicks
mayurilahane Jan 15, 2025
65f84ae
empty state changes
mayurilahane Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Pages/Templates/TemplateDetails/components/Tables/TemplateRepositoriesTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export default function TemplateRepositoriesTable({
}, [snapshotList.length]);

const columnHeaders = [
{ name: 'Repository Name' },
{ name: 'Repository' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be "Name" I think. Check the Jira again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol i think i got lost in code

Right this needs to be "Name"!!

{ name: 'Snapshot Date', width: 20 },
Copy link
Member

@swadeley swadeley Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ name: 'Snapshot Date', width: 20 },
{ name: 'Snapshot date', width: 20 },

In associated Jira, red is used to highlight what is wanted.
EDIT: Maybe it was just sentence case that was asked for, i.e. 'Snapshot date'. I'll ask in Jira for confirmation.

{ name: 'Change', width: 15 },
{ name: 'Packages', width: 15 },
Expand All @@ -98,7 +98,7 @@ export default function TemplateRepositoriesTable({
<Thead>
<Tr>
{columnHeaders.map(({ name, width }, index) =>
name === 'Repository Name' || name === 'Snapshot Date' ? (
name === 'Repository' || name === 'Snapshot Date' ? (
<Th
width={width as BaseCellProps['width']}
key={index + name + '_header'}
Expand Down Expand Up @@ -162,7 +162,7 @@ export default function TemplateRepositoriesTable({
</Hide>
</Flex>
</Td>
<Td>{formatDateDDMMMYYYY(created_at, true)}</Td>
<Td>{formatDateUTC(created_at, true)}</Td>
marusak marked this conversation as resolved.
Show resolved Hide resolved
<Td>
<ChangedArrows
addedCount={added_counts?.['rpm.package'] || 0}
Expand Down
2 changes: 1 addition & 1 deletion src/components/SharedTables/PackagesTable/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export default function PackagesTable({
setPrev(packagesList.length || 10);
}, [packagesList.length]);

const columnHeaders = ['Name', 'Version', 'Release', 'Arch'];
const columnHeaders = ['Name', 'Version', 'Release', 'Architecture'];

return (
<>
Expand Down
Loading