Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix slice init length #3742

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

cuishuang
Copy link

@cuishuang cuishuang commented Oct 4, 2024

What is the feature/fix?

The intention here should be to initialize a slice with a capacity of length rather than initializing the length of this slice.

The online demo: https://go.dev/play/p/q1BcVCmvidW

Add screenshot or video (optional)

** Any screenshot or video capture using the feature **

Does it has a breaking change?

** Describe the changes and if it has any breaking changes in any feature **

How to use/test it?

** Describe how to test or use the feature **

Checklist

  • New coverage tests
  • Unit tests passing
  • E2E tests passing
  • E2E downgrade/update test passing
  • Documentation updated
  • No warnings or errors on Deepsource/Codecov

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.17%. Comparing base (01a2ab5) to head (12a0ae5).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
pkg/manifest1/balancer.go 0.00% 1 Missing ⚠️
provider/aws/releases.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3742      +/-   ##
==========================================
- Coverage   33.56%   33.17%   -0.39%     
==========================================
  Files         180      182       +2     
  Lines       20253    20540     +287     
==========================================
+ Hits         6797     6814      +17     
- Misses      12309    12578     +269     
- Partials     1147     1148       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant