Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix slice init length #3742

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/manifest1/balancer.go
Original file line number Diff line number Diff line change
@@ -102,7 +102,7 @@

func (mb ManifestBalancer) Ports() []string {
pp := mb.Entry.TCPPorts()
sp := make([]string, len(pp))
sp := make([]string, 0, len(pp))

Check warning on line 105 in pkg/manifest1/balancer.go

Codecov / codecov/patch

pkg/manifest1/balancer.go#L105

Added line #L105 was not covered by tests

for _, p := range pp {
sp = append(sp, strconv.Itoa(p.Balancer))
2 changes: 1 addition & 1 deletion provider/aws/releases.go
Original file line number Diff line number Diff line change
@@ -872,7 +872,7 @@
}

entry.Exports = make(map[string]string)
linkableEnvs := make([]string, len(entry.Environment))
linkableEnvs := make([]string, 0, len(entry.Environment))

Check warning on line 875 in provider/aws/releases.go

Codecov / codecov/patch

provider/aws/releases.go#L875

Added line #L875 was not covered by tests
for _, env := range entry.Environment {
linkableEnvs = append(linkableEnvs, fmt.Sprintf("%s=%s", env.Name, env.Value))
}