Fix login failure #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's obviously another account. I do not prefer this changes because it can cause unintended consequence. |
eisuke
force-pushed
the
fix_login_failure
branch
from
01cf9a0 to
ae49794
Compare
Yes, I know it as ideal. The reason for taking this approach is
But I agree this approach is not good. So I redoed it ae49794 (Removing table constaints) |
|
It doesn't look bad 👍 |
eisuke
force-pushed
the
fix_login_failure
branch
from
ae49794 to
0e362cb
Compare
eagletmt
reviewed
Mar 24, 2017
| @@ -0,0 +1,6 @@ | |||
| class DropUniqConstraintUserEmail < ActiveRecord::Migration | |||
| def change | |||
There was a problem hiding this comment.
This should be def up because this migration is irreversible.
There was a problem hiding this comment.
nice catch! fixed e803981
eisuke
force-pushed
the
fix_login_failure
branch
from
0e362cb to
e803981
Compare
eagletmt
reviewed
Mar 31, 2017
app/models/kuroko2/user.rb
Outdated
| @@ -17,8 +17,8 @@ class Kuroko2::User < Kuroko2::ApplicationRecord | |||
| has_many :admin_assignments, dependent: :restrict_with_error | |||
| has_many :assigned_job_definitions, through: :admin_assignments, source: :job_definition | |||
|
|
|||
| validates :name, uniqueness: { case_sensitive: false} , presence: true | |||
| validates :email, uniqueness: { case_sensitive: false}, presence: true | |||
| validates :name, uniqueness: { case_sensitive: false }, presence: true, unless: :google_account? | |||
There was a problem hiding this comment.
The presence should be validated even if google_account?
With a user who email address already exists, But defferrent `uid`
eisuke
force-pushed
the
fix_login_failure
branch
from
e803981 to
149ea35
Compare
eagletmt
approved these changes
Apr 3, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a user who email address already exists, but different uid.
@cookpad/dev-infra 👓