Fix job not being recorded as completed when exit status > 127 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takai
reviewed
May 8, 2017
| @@ -0,0 +1,9 @@ | |||
| class ChangeExitStatusToUnsignedTinyint < ActiveRecord::Migration | |||
| def up | |||
| change_column :executions, :exit_status, 'tinyint(4) unsigned' | |||
There was a problem hiding this comment.
AR migration should be database independent. You might want to use limit: 2 instead of unsigned.
There was a problem hiding this comment.
Makes sense, fixed in ff272e3
takai
reviewed
May 8, 2017
spec/dummy/db/schema.rb
Outdated
| @@ -182,7 +182,7 @@ | |||
| t.datetime "suspended_at" | |||
| t.datetime "created_at" | |||
| t.datetime "updated_at" | |||
| t.index ["email"], name: "email", unique: true, using: :btree | |||
| t.index ["email"], name: "email", using: :btree | |||
Kuroko would fail to record the completion of the job when it exits with status bigger than 127 as it causes an ActiveModel::RangeError.
Thanks! The #56 changes accept it. |
|
Thank you for reviewing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kuroko would fail to record the completion of the job when it exits
with status bigger than 127 as it causes an ActiveModel::RangeError.