Support Rails5.1.0 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cookpad/dev-infra please review. |
eagletmt
approved these changes
May 9, 2017
[rails 5.1.0] Directly inheriting from ActiveRecord::Migration is not supported.
taiki45
reviewed
May 9, 2017
kuroko2.gemspec
Outdated
| @@ -26,6 +26,7 @@ Gem::Specification.new do |s| | |||
| s.add_dependency 'retryable' | |||
| s.add_dependency 'faraday' | |||
| s.add_dependency 'sprockets' | |||
| s.add_dependency 'slim' | |||
There was a problem hiding this comment.
Is this intended? It seems we already have slim-rails and it claims "there is no need to include gem "slim" in your Gemfile.": https://github.com/slim-template/slim-rails
There was a problem hiding this comment.
It is for preventing https://travis-ci.org/cookpad/kuroko2/jobs/225911655 .
But it seems it was another cause. (Maybe the responders gem update was effective )
So I revert this changes 3eb2aa3 .
This reverts commit 1a2dca5.
taiki45
approved these changes
May 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.