Use MutationObserver to observe log for work instance_linker.js correctly #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inohiro
changed the title
|
oh CI failed... I'll confirm it. Maybe arrow function... |
inohiro
force-pushed
the
link_to_parent_from_child_process
branch
from
df34ab7 to
78a1cc1
Compare
eisuke
reviewed
Jun 27, 2017
| } | ||
| var logParent = document.querySelector('#logs tbody'); | ||
| var observer = new MutationObserver(function(mutations) { | ||
| if (mutations.some(function(m) { |
There was a problem hiding this comment.
How about separate as a named function?
inohiro
commented
Jun 27, 2017
| ); | ||
| var MutationObserver = window.MutationObserver || window.WebKitMutationObserver || window.MozMutationObserver; | ||
| if (!MutationObserver) { | ||
| return; |
There was a problem hiding this comment.
PhantomJS supports MutationObserver from 2.0. But It seems that TravisCI uses PhantomJS 1.x currently (as default). So if browser does not support MutationObserver, this function (instance linker) should be disabled.
There was a problem hiding this comment.
But recent modern browsers support MutationObserver like that https://caniuse.com/#feat=mutationobserver
There was a problem hiding this comment.
Thank you about #70. I'll add a test about this.
| $('td.log').each(function() { | ||
| var logText = $(this).html(); | ||
| $(this).html( | ||
| logText.replace(/instance#(\d+)\/(\d+)(?:\s+|\.|$)/, function(match, jobId, instanceId) { |
|
I fix CI failing in #69 🙏 |
|
Merged #69. Please rebase this branch. |
Merged
inohiro
force-pushed
the
link_to_parent_from_child_process
branch
from
6de36ea to
5cb4b5f
Compare
|
It seems ready to go. ping @eisuke ? |
|
👍 |
|
I forgot about this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instance_linker.js that makes hyperlink from child job instance to parent job instance had not worked correctly. This PR changes it works fine.
logs are appended to
#logselement by jQuery. So we need to observe changes of the element with MutationObserver.I'm not sure about JavaScript, if someone have better idea to solve it, please give me comments.
before
after