Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use trusty environment #70

Merged
merged 2 commits into from
Jun 27, 2017
Merged

Use trusty environment #70

merged 2 commits into from
Jun 27, 2017

Conversation

eisuke
Copy link
Member

@eisuke eisuke commented Jun 27, 2017

refs: #68 (comment)

The Trusty environment supports PhantomJS 2.0.
https://docs.travis-ci.com/user/trusty-ci-environment/

@cookpad/dev-infra ?
cc: @inohiro

@eisuke eisuke mentioned this pull request Jun 27, 2017
Merged
eagletmt
eagletmt approved these changes Jun 27, 2017
View reviewed changes
Copy link
Member

@eagletmt eagletmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but I couldn't find phantomjs version information in the document.

@eisuke
Copy link
Member Author

eisuke commented Jun 27, 2017

but I couldn't find phantomjs version information in the document.

It does not seem to be explicit...

Add checking phantomjs version in before_install c2d31cd, it seems to be OK.
https://travis-ci.org/cookpad/kuroko2/jobs/247380415 .

@eisuke eisuke merged commit c216165 into cookpad:master Jun 27, 2017
@eisuke eisuke deleted the use_trusty branch June 27, 2017 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eagletmt eagletmt eagletmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eisuke @eagletmt