-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add Webhook/ External notification provider #3147
Feat: Add Webhook/ External notification provider #3147
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
14127286 | Triggered | Generic Password | 75117af | lang/ro.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
@nullishamy Sorry for the late review. I have completed the refactored notifications for the next release and if you still have time and are able to work on this PR, it would be necessary to adjust your PR according to the new notification handling. You can check my PR to see the migrations and models added: #4525 and you can check out the It would be great if you could adjust your PR accordingly. If you are unable to do so, please let me know so I can close this PR. |
So what actually changed, notification settings? Should I expect more changes to come wrt notifications before I start work on this again? |
@nullishamy It is completed so everything should be final (only bugs if any). Changed: New database structure + models, more/new Notifications and new settings views with more granular control (take a look at the PR to get a better understanding at the new migrations table setup, model and view strucuture). I would suggest closing this PR and opening a new PR a lot of changes you made can be taken from this one but a lot of things are new. Also I think Webhook notifications would probably be a more suiteable name then external notifications or what do you think? |
Right. We can debate names separately. I was already planning on redoing it because of the merge conflicts. |
Closing as the usecase that was going to be supported by this for our deployment (better Discord notifications) has been addressed on its own in the 6 months between this PR being open and now. Additionally lack of motivation to rewrite the whole PR. |
Should allow the bottom entry of #2526 (comment) to be closed off.
This adds the ability to use an external webhook for notifications.