Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add Webhook/ External notification provider #3147

Conversation

nullishamy
Copy link

Should allow the bottom entry of #2526 (comment) to be closed off.

This adds the ability to use an external webhook for notifications.

Copy link

gitguardian bot commented Sep 19, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14127286 Triggered Generic Password 75117af lang/ro.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@peaklabs-dev peaklabs-dev added the 🛠️ Feature Issues requesting a new feature. label Oct 14, 2024
@peaklabs-dev peaklabs-dev changed the title Add external notification service Feat: Add Webhook/ External notification provider Dec 11, 2024
@peaklabs-dev
Copy link
Member

@nullishamy Sorry for the late review. I have completed the refactored notifications for the next release and if you still have time and are able to work on this PR, it would be necessary to adjust your PR according to the new notification handling. You can check my PR to see the migrations and models added: #4525 and you can check out the next branch for now to see the new way of implementing notifications.

It would be great if you could adjust your PR accordingly. If you are unable to do so, please let me know so I can close this PR.

@peaklabs-dev peaklabs-dev added the 💤 Waiting for changes PRs awaiting changes from the author. label Dec 11, 2024
@nullishamy
Copy link
Author

So what actually changed, notification settings? Should I expect more changes to come wrt notifications before I start work on this again?

@peaklabs-dev
Copy link
Member

@nullishamy It is completed so everything should be final (only bugs if any).

Changed: New database structure + models, more/new Notifications and new settings views with more granular control (take a look at the PR to get a better understanding at the new migrations table setup, model and view strucuture).

I would suggest closing this PR and opening a new PR a lot of changes you made can be taken from this one but a lot of things are new.

Also I think Webhook notifications would probably be a more suiteable name then external notifications or what do you think?

@nullishamy
Copy link
Author

Right. We can debate names separately. I was already planning on redoing it because of the merge conflicts.

@nullishamy
Copy link
Author

Closing as the usecase that was going to be supported by this for our deployment (better Discord notifications) has been addressed on its own in the 6 months between this PR being open and now. Additionally lack of motivation to rewrite the whole PR.

@nullishamy nullishamy closed this Dec 22, 2024
@github-actions github-actions bot removed 🛠️ Feature Issues requesting a new feature. 💤 Waiting for changes PRs awaiting changes from the author. labels Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants