-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: New Notification Settings #4525
Merged
andrasbacsai
merged 86 commits into
coollabsio:next
from
peaklabs-dev:separate-success-and-failure-notifications
Dec 11, 2024
Merged
Feat: New Notification Settings #4525
andrasbacsai
merged 86 commits into
coollabsio:next
from
peaklabs-dev:separate-success-and-failure-notifications
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next into notifications
- Add migrations that move email, discord and telegram notifications to the new settings tables for each notification - drop now unused columns form the teams table
- Use new notification relationships - Use trait - Make sure that when a new team is created, notification settings are also created - reorder team model for better readability
- add reachable and unreachable notifications - add docker cleanup notifications - better defaults
Thank you for the PR! |
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs Attention
@andrasbacsai: Fixed!
@andrasbacsai: Fixed!
Changes
false
if one is enabledshared.php
line size reduced and functions moved to a trait and a new shared file so we can test it better andshared.php
becomes more manageableIssues
Images
Email