feat(notification): add Pushover #4543
Conversation
|
cc @peaklabs-dev. |
|
I'm stuck with this error, when opening /notification/pushover 
|
|
@peaklabs-dev To test it you, can follow this guide (random link found on google, but the config steps are similar) https://www.cybercom-software.com/help/phonepadadmin/pushover2.htm Then you can receive notification on your devices |
|
I will check |
| { | ||
| try { | ||
| $this->team = auth()->user()->currentTeam(); | ||
| $this->settings = $this->team->pushoverNotificationSettings(); |
There was a problem hiding this comment.
This line can not have (). it needs to be:
$this->settings = $this->team->pushoverNotificationSettings;
There was a problem hiding this comment.
@zaosoula Found it (at least this should be the issue).
There was a problem hiding this comment.
Perfect thank you
I will proceed with the testing
There was a problem hiding this comment.
It's working
Thanks for the help
zaosoula
force-pushed
the
next-pushover
branch
from
eddf7e1 to
ff810ec
Compare
|
Thank you. So is it ready to be merged? |
zaosoula
force-pushed
the
next-pushover
branch
from
ff810ec to
ef35429
Compare
|
Also I do not understand what to use for the user I need to use my user key right? |
|
@peaklabs-dev The user and token values got inverted by an error in my code it fixed now. |
|
Give me a minute to test if it works, If I can get it to work I will do the docs for you. |
|
Thank you for the PR and your fast fixing of the issues. I will add a few small cosmetic fixes. |
Changes