Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang, cli, spl: Update solana toolchain to v1.9.13 #1653

Merged
merged 25 commits into from
Mar 27, 2022

Conversation

fanatid
Copy link
Contributor

@fanatid fanatid commented Mar 20, 2022

Close #1375

Probably I need to update also lock files in tests 🤔, will check and push changes if required.

edited:

@dovahcrow
Copy link

Move to Solana 1.9 is very important because of the change of the zstd version (a C library), you cannot even have solana_* 1.8 and solana_* 1.9 coexist in the same library which breaks applications who is depending on both anchor 0.22/0.23 and solana 1.9.

e.g.

...
versions that meet the requirements ^0.5.1 are: 0.5.4+zstd.1.4.7, 0.5.3+zstd.1.4.5, 0.5.2+zstd.1.4.5, 0.5.1+zstd.1.4.4
the package zstd links to the native library zstd, but it conflicts with a previous package which links to zstd as well:
package zstd v0.9.0+zstd.1.5.0
... which satisfies dependency zstd = "^0.9.0" of package solana-account-decoder v1.9.13 (ssh://git@github.com/dovahcrow/solana-mole.git?branch=mole#4182d566)
... which satisfies git dependency solana-account-decoder of package solana-client v1.9.13 (ssh://git@github.com/dovahcrow/solana-mole.git?branch=mole#4182d566)

@@ -239,6 +239,55 @@ jobs:
- run: cd tests/bpf-upgradeable-state && cp bpf_upgradeable_state-keypair.json target/deploy/bpf_upgradeable_state-keypair.json && anchor test --skip-local-validator --skip-build --skip-lint
- uses: ./.github/actions/git-diff/

# this test exists to make sure that anchor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: let's do 80 chars for comments

@paul-schaaf paul-schaaf changed the title lang, cli, spl: Update solana toolchain to v1.9.0 lang, cli, spl: Update solana toolchain to v1.9.13 Mar 26, 2022
@@ -0,0 +1,4 @@
#!/bin/sh

rm ./tests/misc.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add a comment here for future readers.

@paul-schaaf paul-schaaf merged commit 40ea715 into coral-xyz:master Mar 27, 2022
@fanatid fanatid deleted the solana-update branch April 10, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update solana crates to 1.9
4 participants