-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add git diff for checking lock file changes #1654
Conversation
just to make sure I understand correctly, is the reason for adding this that |
Yes, purpose of this changes to validate that dependencies on CI (rust/js) will be same as on developer computer. |
is this ready for review? |
Yes, it's ready. One thing I do not like that submodules like |
Ideally we should use but we could use that for building our code in the CI (if it does what I think it does) |
We can pass $ cargo build-bpf -- --locked
BPF SDK: /home/kirill/.local/share/solana/install/releases/1.9.13/solana-release/bin/sdk/bpf
cargo-build-bpf child: rustup toolchain list -v
cargo-build-bpf child: cargo +bpf build --target bpfel-unknown-unknown --release --locked While I think that would be good to add |
oh thats right nice! Lets do it then. keeping |
Updated. |
Moved from #1653