Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 3DS game handling #25

Open
corbindavenport opened this issue Jun 11, 2024 · 3 comments
Open

Improve 3DS game handling #25

corbindavenport opened this issue Jun 11, 2024 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@corbindavenport
Copy link
Owner

Animal Crossing screenshots don't work after #22 was merged. It might also make sense to move the game lists out of the code repository, or at least make it easily synchronized with the original source.

@corbindavenport corbindavenport added bug Something isn't working enhancement New feature or request labels Jun 11, 2024
@corbindavenport corbindavenport self-assigned this Jun 11, 2024
@spaghefoo
Copy link
Contributor

could you give me an animal crossing jpg screenshot from a 3ds? i don't have the game to test this one...

@corbindavenport
Copy link
Owner Author

The sample image in the repo has the metadata: https://github.com/corbindavenport/imageshare/blob/main/sample.jpg

@spaghefoo
Copy link
Contributor

After checking yesterday, the titleID associated with the image was actually pointing on an update. We didn't check for updates titleIDs(which have a distinct titleID pattern) because when writing the code i thought "we don't need to check for game updates it's only games we are interested in.". It seems like animal crossing proved me wrong somehow. now it works for animal crossing, however it shows as "Animal Crossing™: New Leaf Update Ver. 1.5".
I also encounted an other(small) issue where when uploading some game images(Pokémon sun for example) it would show as : Update. I modifed the code a bit to fix that.
I'll check for the json repo thing at a later date but the main issue is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants