Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for animal crossing issue #26

Closed
wants to merge 5 commits into from

Conversation

spaghefoo
Copy link
Contributor

As mentionned in #25 here's the fix for animal crossing now showing up anymore + miscellaneous fix.

I'll look into syncronising the json later

@corbindavenport
Copy link
Owner

Sorry for taking so long to get to this! I started working on the Node.js rewrite (#28), and now that I know that will be the new codebase for the project, I re-implemented the hax0kartik database and all your changes in JS: 452eabf

The behavior should match your implementation, with original game titles preferred over the updated versions. The one big change I made is that the game database is combined and sorted at server startup, instead of happening on each upload. I also made some overrides for game IDs that get reused a lot.

The updated title detection is live now in the node-rewrite branch and on the main site, and it will be in the next release once that's ready. Let me know if you notice any bugs compared to your PHP implementation, and thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants