Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing 3ds game detection to be more accurate #22

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

spaghefoo
Copy link
Contributor

Hello,
While working on another python project similar to this(instead of publishing to imgbb and imgur it publishes to mastodon basically), i noticed that the 3dsreleases.xml file used here is partially wrong, As i checked the software exif values of images from my 3ds and it didn't hit.(notably pokémon rumble world and smash bros didn't hit and team kirby clash deluxe had a different title id for some reason). Also not all regions were supported.

I found a github that provided jsons and xml( https://github.com/hax0kartik/3dsdb ) that got it's values from nintendo eshop server directly for all regions so it's more accurate and i implemented them here.

Thank you

@corbindavenport
Copy link
Owner

Nice, I'll check this out when I get some free time. It might make more sense to pull directly from that repo during the build process instead of bundling all the game lists in the ImageShare repository, but I'll have to check what's possible there.

@corbindavenport corbindavenport merged commit ac8d594 into corbindavenport:main Jun 11, 2024
@corbindavenport
Copy link
Owner

Thanks for this! I added a check so the EXIF code doesn't run on unsupported file formats, otherwise PNG files show an error.

I tried screenshots from Pokemon X, Smash Bros, and 3D World, and they all seemed to work. Animal Crossing screenshots don't show the game title anymore, though. This is an overall improvement so I'm leaving this merged (and included it in the v24.06 release), but I opened #25 to look into the Animal Crossing issue and possibly other missing titles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants