Changing 3ds game detection to be more accurate #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
While working on another python project similar to this(instead of publishing to imgbb and imgur it publishes to mastodon basically), i noticed that the 3dsreleases.xml file used here is partially wrong, As i checked the software exif values of images from my 3ds and it didn't hit.(notably pokémon rumble world and smash bros didn't hit and team kirby clash deluxe had a different title id for some reason). Also not all regions were supported.
I found a github that provided jsons and xml( https://github.com/hax0kartik/3dsdb ) that got it's values from nintendo eshop server directly for all regions so it's more accurate and i implemented them here.
Thank you