-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
providers: Add "akamai" provider #1062
Conversation
@nesv Awesome, thank you for doing this! Took a quick look at it, and overall it looks sane, I need to do some double checking on some of the meat of the mod.rs but so far so good! |
Thanks a bunch, @prestist! I misunderstood how serde handles deserializing untagged enums. I had hoped I could use an enum to enumerate all possible values for a field, but it would seem that isn't possible; I have removed the |
I was hoping to provide an as-complete-as-possible |
The latest patches have been checked, and they work! All of the fixup commits have been squashed and rebased onto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, same as the Ignition PR (coreos/ignition#1841) it has been tested on Flatcar and it works as expected on Akamai/Linode from a functional aspect.
@jlebon Requested changes have been made! Thank you for taking the time to review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, though looks like there are a few lints to address. While we're here, can you squash your fixup commits together? We don't "Squash and merge" in this repo.
Gah, oversights on my part. I'll get those fixed up.
Absolutely! I was planning on squashing my own fixup commits out anyways. 😄 |
The "akamai" provider adds support for retrieving configuration from Akamai Connected Cloud's (a.k.a. Linode) [Metadata Service][metadata-service]. References: flatcar/Flatcar#1404 References: coreos/fedora-coreos-tracker#1701 References: coreos/ignition#1841 [metadata-service]: https://www.linode.com/docs/products/compute/compute-instances/guides/metadata/
@jlebon Fixup commits squashed, and I've applied the linting suggestions. |
The "akamai" provider adds support for retrieving configuration from Akamai Connected Cloud's (a.k.a. Linode) Metadata Service.
References: flatcar/Flatcar#1404
References: coreos/fedora-coreos-tracker#1701
References: coreos/ignition#1841
Note
I'll push any requested changes as fixup commits, just so that the Github comment threads don't get messed up. If this PR is approved, I will squash these fixup commits out prior to merge.