-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
providers: add "akamai" provider #1841
Conversation
Thank you for working on this! Could you create a platform request issue on https://github.com/coreos/fedora-coreos-tracker/issues and add it to this issue's work? There a a number of moving parts so it would be nice to track it there :) |
Hi @prestist! You're most welcome! I have filed a tracking ticket: coreos/fedora-coreos-tracker#1701. |
Can you add |
For what it's worth, I'll add any requested changes as fixup commits just so that comments stay with the referenced code. I will rebase to squash out the fixup commits prior to merging if everything looks good. |
68b1d18
to
62725fd
Compare
I have added it to the commit message for 6cb1703. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @nesv should we kick-off a Flatcar build with this patch in order to provide an image that you could test on Linode? We would catch any issue before merging this PR.
@nesv Thank you for being so quick to address our comments! |
@tormath1 Latest changes have been pushed! |
The "akamai" provider adds support for retrieving an ignition configuration from Akamai Connected Cloud's (a.k.a. Linode) [Metadata Service][metadata-service]. References: flatcar/Flatcar#1404 References: coreos/fedora-coreos-tracker#1701 References: coreos/ignition#1841 [metadata-service]: https://www.linode.com/docs/products/compute/compute-instances/guides/metadata/
The "akamai" provider adds support for retrieving configuration from Akamai Connected Cloud's (a.k.a. Linode) [Metadata Service][metadata-service]. References: flatcar/Flatcar#1404 References: coreos/fedora-coreos-tracker#1701 References: coreos/ignition#1841 [metadata-service]: https://www.linode.com/docs/products/compute/compute-instances/guides/metadata/
@tormath1 The latest image you provided works! I have squashed out all of the fixup commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, but looks sane to me overall.
Release note commit would probably be cleaner squashed.
@jlebon Thank you for the review! I've made the changes you requested. |
The "akamai" provider adds support for retrieving an ignition configuration from Akamai Connected Cloud's (a.k.a. Linode) [Metadata Service][1]. See: flatcar/Flatcar#1404 See: coreos/fedora-coreos-tracker#1701 Fixes: coreos#1508 [1]: https://www.linode.com/docs/products/compute/compute-instances/guides/metadata/ docs: Add Akamai/Linode provider to release notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Will hand it off to @prestist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, this patch has been tested with Flatcar images on Linode. On the functional aspect, it works as expected.
The "akamai" provider adds support for retrieving configuration from Akamai Connected Cloud's (a.k.a. Linode) [Metadata Service][metadata-service]. References: flatcar/Flatcar#1404 References: coreos/fedora-coreos-tracker#1701 References: coreos/ignition#1841 [metadata-service]: https://www.linode.com/docs/products/compute/compute-instances/guides/metadata/
The "akamai" provider adds support for retrieving configuration from Akamai Connected Cloud's (a.k.a. Linode) [Metadata Service][metadata-service]. References: flatcar/Flatcar#1404 References: coreos/fedora-coreos-tracker#1701 References: coreos/ignition#1841 [metadata-service]: https://www.linode.com/docs/products/compute/compute-instances/guides/metadata/
The "akamai" provider adds support for retrieving an ignition configuration from Akamai Connected Cloud's (a.k.a. Linode) Metadata Service.
See flatcar/Flatcar#1404
See coreos/fedora-coreos-tracker#1701