Support DHCP option lookup from NetworkManager #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
prestist
reviewed
Jan 31, 2023
prestist
reviewed
Jan 31, 2023
This will allow us to try multiple network managers in sequence. This causes us to look up the available interfaces on every try, rather than just once. Interface lookup shouldn't be expensive, and recognizing new interfaces is probably useful anyway.
Check both NetworkManager and networkd on each retry iteration. The NetworkManager check works with both dhclient and NM's internal DHCP client. Avoids a 30-second boot delay on Azure and AzureStack as we time out waiting for a networkd lease. Doesn't help in the initrd on RHCOS 8, since NetworkManager doesn't daemonize there. Support zbus 2.3 because Fedora isn't shipping zbus 3 yet. The two are API-compatible for our purposes. Tested on Azure on Flatcar and RHEL in the real root, and FCOS in the initrd. Not tested on CloudStack, except to verify that NetworkManager exposes a dhcp_server_identifier DHCP option with the expected format. Fixes #146.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read DHCP options from NetworkManager and networkd in parallel. The NetworkManager check works with both dhclient and NM's internal DHCP client. Avoids a 30-second boot delay on Azure and AzureStack as we time out waiting for a networkd lease. Doesn't help in the initrd on RHCOS 8, since NetworkManager doesn't daemonize there.
Support zbus 2.3 because Fedora isn't shipping zbus 3 yet. The two are API-compatible for our purposes.
Tested on Azure on Flatcar and RHEL in the real root, and FCOS in the initrd. Not tested on CloudStack, except to verify that NetworkManager exposes a
dhcp_server_identifierDHCP option with the expected format.Fixes #146.