Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DHCP option lookup from NetworkManager #861

Merged
merged 4 commits into from
Feb 1, 2023
Merged

Support DHCP option lookup from NetworkManager #861

merged 4 commits into from
Feb 1, 2023

Commits on Jan 31, 2023

  1. Configuration menu
    Copy the full SHA
    122916c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    09193a5 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. util: factor out retries of DHCP option lookup

    This will allow us to try multiple network managers in sequence.
    
    This causes us to look up the available interfaces on every try, rather
    than just once.  Interface lookup shouldn't be expensive, and recognizing
    new interfaces is probably useful anyway.
    bgilbert committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    d0cddbc View commit details
    Browse the repository at this point in the history
  2. util: support DHCP option lookup from NetworkManager

    Check both NetworkManager and networkd on each retry iteration.  The
    NetworkManager check works with both dhclient and NM's internal DHCP
    client.  Avoids a 30-second boot delay on Azure and AzureStack as we time
    out waiting for a networkd lease.  Doesn't help in the initrd on RHCOS 8,
    since NetworkManager doesn't daemonize there.
    
    Support zbus 2.3 because Fedora isn't shipping zbus 3 yet.  The two are
    API-compatible for our purposes.
    
    Tested on Azure on Flatcar and RHEL in the real root, and FCOS in the
    initrd.  Not tested on CloudStack, except to verify that NetworkManager
    exposes a dhcp_server_identifier DHCP option with the expected format.
    
    Fixes #146.
    bgilbert committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    105eb25 View commit details
    Browse the repository at this point in the history