grub2: source in a console.cfg file if exists #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow users or distro builders place console settings here that will get picked up on boot. This was discussed as part of coreos/fedora-coreos-tracker#1671
|
Skipping CI for Draft Pull Request. |
|
/test all |
|
Creating as draft because I still need to test this in concert with other changes |
dustymabe
added a commit
to dustymabe/fedora-coreos-config
that referenced
this pull request
Feb 19, 2024
See coreos/fedora-coreos-tracker#1671 where we discovered that having this be a static config delivered by bootupd was a bad idea. Instead we'll have something else create a file in /boot/grub2/console.cfg (most likely osbuild/osbuild#1589) and we'll have the bootupd static grub configs source it (coreos/bootupd#619).
This was referenced Feb 19, 2024
dustymabe
added a commit
to dustymabe/fedora-coreos-config
that referenced
this pull request
Feb 21, 2024
See coreos/fedora-coreos-tracker#1671 where we discovered that having this be a static config delivered by bootupd was a bad idea. Instead we'll have something else create a file in /boot/grub2/console.cfg (most likely osbuild/osbuild#1589) and we'll have the bootupd static grub configs source it (coreos/bootupd#619).
|
ok this is looking good in testing I think! |
jlebon
approved these changes
Feb 21, 2024
dustymabe
added a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Feb 22, 2024
See coreos/fedora-coreos-tracker#1671 where we discovered that having this be a static config delivered by bootupd was a bad idea. Instead we'll have something else create a file in /boot/grub2/console.cfg (most likely osbuild/osbuild#1589) and we'll have the bootupd static grub configs source it (coreos/bootupd#619).
dustymabe
added a commit
to marmijo/fedora-coreos-config
that referenced
this pull request
Feb 22, 2024
This has a backport of coreos/bootupd#619 to support GRUB console settings in console.cfg. Seee coreos/fedora-coreos-tracker#1671
dustymabe
added a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Feb 23, 2024
This has a backport of coreos/bootupd#619 to support GRUB console settings in console.cfg. Seee coreos/fedora-coreos-tracker#1671
aaradhak
pushed a commit
to aaradhak/fedora-coreos-config
that referenced
this pull request
Mar 18, 2024
See coreos/fedora-coreos-tracker#1671 where we discovered that having this be a static config delivered by bootupd was a bad idea. Instead we'll have something else create a file in /boot/grub2/console.cfg (most likely osbuild/osbuild#1589) and we'll have the bootupd static grub configs source it (coreos/bootupd#619).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow users or distro builders place console settings here that will get picked up on boot. This was discussed as part of coreos/fedora-coreos-tracker#1671