-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grub2: source in a console.cfg file if exists #619
Conversation
This will allow users or distro builders place console settings here that will get picked up on boot. This was discussed as part of coreos/fedora-coreos-tracker#1671
Skipping CI for Draft Pull Request. |
/test all |
Creating as draft because I still need to test this in concert with other changes |
See coreos/fedora-coreos-tracker#1671 where we discovered that having this be a static config delivered by bootupd was a bad idea. Instead we'll have something else create a file in /boot/grub2/console.cfg (most likely osbuild/osbuild#1589) and we'll have the bootupd static grub configs source it (coreos/bootupd#619).
See coreos/fedora-coreos-tracker#1671 where we discovered that having this be a static config delivered by bootupd was a bad idea. Instead we'll have something else create a file in /boot/grub2/console.cfg (most likely osbuild/osbuild#1589) and we'll have the bootupd static grub configs source it (coreos/bootupd#619).
ok this is looking good in testing I think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
See coreos/fedora-coreos-tracker#1671 where we discovered that having this be a static config delivered by bootupd was a bad idea. Instead we'll have something else create a file in /boot/grub2/console.cfg (most likely osbuild/osbuild#1589) and we'll have the bootupd static grub configs source it (coreos/bootupd#619).
This has a backport of coreos/bootupd#619 to support GRUB console settings in console.cfg. Seee coreos/fedora-coreos-tracker#1671
This has a backport of coreos/bootupd#619 to support GRUB console settings in console.cfg. Seee coreos/fedora-coreos-tracker#1671
See coreos/fedora-coreos-tracker#1671 where we discovered that having this be a static config delivered by bootupd was a bad idea. Instead we'll have something else create a file in /boot/grub2/console.cfg (most likely osbuild/osbuild#1589) and we'll have the bootupd static grub configs source it (coreos/bootupd#619).
This will allow users or distro builders place console settings here that will get picked up on boot. This was discussed as part of coreos/fedora-coreos-tracker#1671