-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update customize image test to fix ci #1478
Conversation
Cool new context; Comparing notes with the logs and the expected checks.
check_dest() {
! assert @applied-live-ign@
! assert @applied-live-2-ign@
assert @applied-dest-ign@
assert @applied-dest-2-ign@
! assert @preinst-1@
! assert @preinst-2@
! assert @postinst-1@
! assert @postinst-2@
assert 'Adding "coreos-installer test certificate" to list of CAs'
} |
Okay, looking more closely The dest.ign/dest.bu in the fixtures has some conditionals which are currently failing. You can see that in the logs from #1474
This needs to exist.. but does not so consequently we fail. |
926a3f2
to
31d2e78
Compare
Get CI failed in
|
be04223
to
6471ec1
Compare
@HuijingHei Is there a way to repo this locally? I am not super familiar with these image tests. |
Looks like it's running this script: https://github.com/coreos/coreos-installer/blob/main/.cci.jenkinsfile#L47 |
Get The problem is need to confirm if we still need the serial grep.
|
See Timothée's comment, what I did for testing:
Edit |
@travier Thank you! |
Good question, not sure it is because the change of coreos/fedora-coreos-tracker#1671 |
So debuging locally; I have been able to repo it and I ended up doing a cosa run qemu and messed with the image and creating my own unit with the same exec-start. It failed of course, I think we have two actionable steps.
I still cannot tell why it has become suddenly broken; as all changes seem to be from months or more ago but it is what it is. |
I do not think this will work.
|
Wow, I had no idea about this. I need to read up on OSBuild. The error is consistent with serial not being in the grub config which lead me there, I need to research how the console.cfg gets layered into the grub.cfg |
@HuijingHei so this makes sense, somthing must be responsable for running the grub2-mkconfig to create the new grub.cfg right? Locally running fcos and From my understanding the grub.cfg should be updated with the composed information from the link you provided? |
Not quite sure about Inspired by @mike-nguyen, build with legacy cosa using
when I check on qcow2.disk using
|
It would have to be before we are booted.
Yeah I think so. I suspect that we have an issue going on there. : we could revert the change and go back to doing both until we know why ? It would get us passing without failing ci here.
Thats from the old build method right? well we know the change now. The builder is not doing grub2-mkconfig. @jlebon wdyt we should do? does osbuilder have the ability to mount and run grub2-mkconfig ? |
The context here is that when building with OSBuild, how GRUB configs are set up is different. You can find more details in coreos/fedora-coreos-tracker#1671 and the links there, but the TL;DR is that (1) a stub So... I think all we need here is diff --git a/fixtures/customize/dest.bu b/fixtures/customize/dest.bu
index 1e17035..219422a 100644
--- a/fixtures/customize/dest.bu
+++ b/fixtures/customize/dest.bu
@@ -23,7 +23,7 @@ systemd:
[Service]
Type=oneshot
RemainAfterExit=true
- ExecStart=/bin/grep -qz 'serial --unit=0 --speed=115200 --word=8 --parity=no.terminal_input serial.terminal_output serial.#' /boot/grub2/grub.cfg
+ ExecStart=/bin/grep -qz 'serial --unit=0 --speed=115200 --word=8 --parity=no.terminal_input serial.terminal_output serial.#' /boot/grub2/grub.cfg /boot/grub2/console.cfg
ExecStart=/bin/echo @applied-dest-ign@
StandardOutput=tty (and regenerate I'll let one of you verify that this fixes the tests and open a PR for it since you did most of the work to investigate this (nice work!). :) |
@jlebon Yep it works locally going to make a commit and push. Thank you! |
20f0915
to
7a9b187
Compare
1c9c027
to
a9a6439
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor tweaks, otherwise LGTM.
First commit could use a commit message (what warnings?).
NetworkManager produces a warning if an interface name exceeds 15 chars, resulting in errors such as: 'failed to load connection: invalid connection 'nmstate-yaml-eth2': interface name is longer than 15 characters'. To reduce these warnings, update network interface names to ensure they are within this character limit.
With the changeover to OSBuild, GRUB configs are handled slightly diffrently. Update butane and ignition files to reflect that. fixes coreos#1479
a9a6439
to
9e2933d
Compare
Seeing a failure regarding greps; need to find which one is failing; changed assert to see what is happening.
#1474 (comment)