Stabilise openshift 4.18 on Ignition 3.4.0 spec

[yasminvalim]

Here’s what this PR aims to achieve:

• Stabilise Openshift 4.18
• Uses Ignition 3.4 specs
• Add specs 4.19.0-experimental
• Remove GRUB password support from OCP 4.18

Fixes: #564

[travier]

Commit split that should help review:

• 1rst commit: Fix the 4.17.0 imports that we missed from a previous PR
• 2nd commit: All the changes needed to stabilize 4.18.0, dropping down to ignition 3.4.0, fcos 1.5.0, base 0.5
• 3rd commit: Add 4.19.0-exp, which is copied from 4.18 before the stabilization, and based on latest exp for ignition, fcos & base
• 4th commit: Rebuild the docs

[yasminvalim]

Commit split that should help review:

• 1rst commit: Fix the 4.17.0 imports that we missed from a previous PR
• 2nd commit: All the changes needed to stabilize 4.18.0, dropping down to ignition 3.4.0, fcos 1.5.0, base 0.5
• 3rd commit: Add 4.19.0-exp, which is copied from 4.18 before the stabilization, and based on latest exp for ignition, fcos & base
• 4th commit: Rebuild the docs

Thanks for the guidance! I’ve reorganized the commits based on the example you provided, and it should be easier to review now. Let me know if you think any further changes are needed.

Also, do we need to remove the GRUB password support like we did in the last stabilization? If so, I’ll create a separate commit for that change.

[travier]

Yes, 4.18 will not have GRUB password support in the MCO so we need to remove it there.

[yasminvalim]

Yes, 4.18 will not have GRUB password support in the MCO so we need to remove it there.

Nice, I added one more commit to remove it. I think we are good now, the commit are properly organized.

[travier]

Failing on:

Error: config/openshift/v4_18/translate.go:307:6: func `translateUserGrubCfg` is unused (unused)
  func translateUserGrubCfg(config *types.Config, ts *translate.TranslationSet) translate.TranslationSet {
       ^

[travier]

Some more splitting to make this easier to review. I'll do the update.

[travier]

This LGTM now. @prestist Can I let you take a final quick look and merge this? Thanks

[yasminvalim]

@travier Thank you!

[prestist]

@travier sure thing :) thank you both for your efforts on this, looking now

[prestist]

LGTM, I dont see any issues. Great work all, Thank you for getting this done 🚀