mantle/ore: glcoud: add ability to specify image description for gcp uploads #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in upload.go This should have been done as part of 5cab86f.
|
there is a 2nd commit in there to fix a problem introduced in 5cab86f - so please review that too |
…uploads GCP expects a certain image description to be attached to images in the format of `DISTRO, DISTRO RELEASE, VERSION, INFO`. We need to be able to specify a description for our images when they are created.
dustymabe
force-pushed
the
dusty-ore-add-description
branch
from
4626f68
to
2d16909
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bgilbert, dustymabe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCP expects a certain image description to be attached to images in the
format of
DISTRO, DISTRO RELEASE, VERSION, INFO. We need to be able tospecify a description for our images when they are created.