Jenkinsfile: add description for the GCP uploaded image #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
depends on coreos/coreos-assembler#1328 |
bgilbert
approved these changes
Apr 7, 2020
| @@ -424,13 +424,15 @@ lock(resource: "build-${params.STREAM}") { | |||
| utils.shwrap(""" | |||
| # pick up the project to use from the config | |||
| gcp_project=\$(jq -r .project_id \${GCP_IMAGE_UPLOAD_CONFIG}) | |||
| today=\$(date +%Y-%m-%d) | |||
There was a problem hiding this comment.
Are we concerned about time zones?
There was a problem hiding this comment.
i'm not. It's purely informational
For public images GCP would like for the description of the image to be in the format: `DISTRO, DISTRO RELEASE, VERSION, INFO` so that information can get pulled into web UIs and documentation. Let's start with something like: ``` Fedora CoreOS, Fedora CoreOS stable, 31.20200310.3.0, x86_64 published on 2020-03-25 ```
dustymabe
force-pushed
the
dusty-gcp-description
branch
from
71f9d6b
to
3960514
Compare
|
force pushed a change to fix quotations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For public images GCP would like for the description of the image to be
in the format:
DISTRO, DISTRO RELEASE, VERSION, INFOso that informationcan get pulled into web UIs and documentation. Let's start with something
like: