kola/tests/ignition: add test for checking journald logs #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
reviewed
Apr 9, 2020
sohankunkerkar
force-pushed
the
ign-kola-test
branch
2 times, most recently
from
f8eac5c
to
303d493
Compare
|
Waiting for a new release of |
sohankunkerkar
force-pushed
the
ign-kola-test
branch
2 times, most recently
from
6302f96
to
946202b
Compare
sohankunkerkar
changed the title
cgwalters
reviewed
May 8, 2020
ashcrow
reviewed
May 8, 2020
zonggen
reviewed
May 8, 2020
sohankunkerkar
force-pushed
the
ign-kola-test
branch
5 times, most recently
from
20ae9cd
to
15b6bd6
Compare
sohankunkerkar
force-pushed
the
ign-kola-test
branch
from
15b6bd6
to
9871951
Compare
ashcrow
approved these changes
May 11, 2020
|
|
||
| func sendJournaldLog(c cluster.TestCluster) { | ||
| m := c.Machines()[0] | ||
| // See https://github.com/coreos/ignition/pull/958 |
| // for the MESSAGE_ID source. It will track the | ||
| // journal messages related to an ignition config | ||
| // provided by the user. | ||
| out := c.MustSSH(m, fmt.Sprintf("journalctl -o json-pretty MESSAGE_ID=%s | jq -s '.[] | select(.IGNITION_CONFIG_TYPE == \"user\")' | wc -l", ignitionJournalMsgId)) |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters, sohankunkerkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test will validate the changes in coreos/ignition#958 to see if we're successfully sending the journald log entry for a
user-providedconfig.