Enable logging to the systemd journal if a user config is provided #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
sohankunkerkar
force-pushed
the
ign-journal
branch
9 times, most recently
from
149589d
to
455a59f
Compare
sohankunkerkar
force-pushed
the
ign-journal
branch
from
455a59f
to
ebf2609
Compare
jlebon
reviewed
Apr 7, 2020
sohankunkerkar
force-pushed
the
ign-journal
branch
2 times, most recently
from
64d27d4
to
6b6d860
Compare
jlebon
reviewed
Apr 7, 2020
There was a problem hiding this comment.
Would be cool to add a test for this! And actually, with the new "external" host tests, this could be done pretty easily by just adding a script to tests/kola/ that greps the journal for messages with the given ID.
More generic testing where e.g. you provided referenced user configs or you don't provide a user config at all would require an internal kola test in cosa though.
sohankunkerkar
force-pushed
the
ign-journal
branch
3 times, most recently
from
5888984
to
3c0373c
Compare
sohankunkerkar
force-pushed
the
ign-journal
branch
from
3c0373c
to
bf6438d
Compare
jlebon
reviewed
Apr 9, 2020
dustymabe
reviewed
Apr 9, 2020
sohankunkerkar
force-pushed
the
ign-journal
branch
2 times, most recently
from
7e4ee81
to
29f08f6
Compare
dustymabe
reviewed
Apr 9, 2020
dustymabe
reviewed
Apr 9, 2020
dustymabe
approved these changes
Apr 9, 2020
sohankunkerkar
force-pushed
the
ign-journal
branch
from
29f08f6
to
7b0123d
Compare
sohankunkerkar
changed the title
jlebon
reviewed
Apr 14, 2020
sohankunkerkar
force-pushed
the
ign-journal
branch
2 times, most recently
from
7bf3206
to
67e778e
Compare
jlebon
reviewed
Apr 14, 2020
sohankunkerkar
force-pushed
the
ign-journal
branch
2 times, most recently
from
c74ecbd
to
250bcf4
Compare
dustymabe
reviewed
Apr 14, 2020
jlebon
approved these changes
Apr 14, 2020
sohankunkerkar
force-pushed
the
ign-journal
branch
2 times, most recently
from
f7c6f55
to
8f4bfd5
Compare
sohankunkerkar
force-pushed
the
ign-journal
branch
from
8f4bfd5
to
b372a69
Compare
|
LGTM |
jlebon
added a commit
to jlebon/ignition
that referenced
this pull request
Jul 16, 2020
Regression from coreos#958. We switched the list of providers from an array to a map. But iteration order through a map is undefined, so we lost the precedence of providers. I think this is the cause behind a lot of the FCOS installer test timeouts, such as: coreos/coreos-assembler#1597 There, we pass the Ignition config for the PXE boot via `ignition.config.url`, but if the metal (no-op) fetcher appears earlier than the `cmdline` fetcher, we get no config. And similarly for the installed system when the no-op fetcher appears before the `system` fetcher (which coreos-installer's `--ignition-file` leverages). The likelihood of this happening increased in the v2.4.0 release due to coreos#1002, which only gave us one try to iterate over the correct provider first (at the `fetch` stage), rather than every stage having a go at it. Closes: coreos/coreos-assembler#1597
jlebon
added a commit
to jlebon/ignition
that referenced
this pull request
Jul 16, 2020
Regression from coreos#958. We switched the list of providers from an array to a map. But iteration order through a map is undefined, so we lost the precedence of providers. I think this is the cause behind a lot of the FCOS installer test timeouts, such as: coreos/coreos-assembler#1597 There, we pass the Ignition config for the PXE boot via `ignition.config.url`, but if the metal (no-op) fetcher appears earlier than the `cmdline` fetcher, we get no config. And similarly for the installed system when the no-op fetcher appears before the `system` fetcher (which coreos-installer's `--ignition-file` leverages). The likelihood of this happening increased in the v2.4.0 release due to coreos#1002, which only gave us one try to iterate over the correct provider first (at the `fetch` stage), rather than every stage having a go at it. Closes: coreos/coreos-assembler#1597
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #903