Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kola/tests: add /var/lib/containers to separate disk test #1469

Merged
merged 1 commit into from
Jan 16, 2024
Merged

kola/tests: add /var/lib/containers to separate disk test #1469

merged 1 commit into from
Jan 16, 2024

Conversation

mike-nguyen
Copy link
Member

Customers have requested the ability to use a separate disk for
/var/lib/containers as a day two operation. This is a sanity
test that makes sure this can be done with systemd units as
described in the knowlege base article [0].

[0] https://access.redhat.com/solutions/4952011

@mike-nguyen
Copy link
Member Author

/retest

1 similar comment
@mike-nguyen
Copy link
Member Author

/retest

@mike-nguyen mike-nguyen changed the title kola/tests: add /var/lib/containers to separate disk test WIP: kola/tests: add /var/lib/containers to separate disk test Jul 13, 2020
@mike-nguyen
Copy link
Member Author

Adding WIP label. Need to fix a few things due to #1573

@arithx
Copy link
Contributor

arithx commented Jul 14, 2020

Adding WIP label. Need to fix a few things due to #1573

Whoops sorry about that Mike, forgot to check open PRs to see if anything would be affected.

@mike-nguyen
Copy link
Member Author

Adding WIP label. Need to fix a few things due to #1573

Whoops sorry about that Mike, forgot to check open PRs to see if anything would be affected.

No worries. I don't know if looking at open PRs should be a thing since sometimes PRs get closed/changed.

@mike-nguyen mike-nguyen force-pushed the vlc_disk branch 2 times, most recently from d74d8be to c7c3076 Compare July 15, 2020 14:26
@mike-nguyen mike-nguyen changed the title WIP: kola/tests: add /var/lib/containers to separate disk test kola/tests: add /var/lib/containers to separate disk test Jul 15, 2020
@mike-nguyen mike-nguyen force-pushed the vlc_disk branch 2 times, most recently from 39c3319 to f1962ea Compare July 15, 2020 18:13
@mike-nguyen
Copy link
Member Author

/retest

@mike-nguyen
Copy link
Member Author

Lifting WIP. This should work with the recent changes now.

@ashcrow ashcrow requested review from arithx and bgilbert July 24, 2020 15:39
arithx
arithx reviewed Jul 24, 2020
View reviewed changes
mantle/kola/tests/misc/disk.go Outdated Show resolved Hide resolved
mantle/kola/tests/misc/disk.go Show resolved Hide resolved
@mike-nguyen
Copy link
Member Author

Addressed comments ⬆️ If there are no other comments this is ready to go.

arithx
arithx approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@arithx arithx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arithx, mike-nguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bgilbert bgilbert removed their request for review July 28, 2023 06:51
@jlebon jlebon closed this Jan 15, 2024
@jlebon jlebon reopened this Jan 15, 2024
jlebon
jlebon previously approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ancient now, but still seems useful and code still looks sane (and still does not have any merge conflicts!).

Restarted CI.

jlebon
jlebon previously approved these changes Jan 15, 2024
View reviewed changes
@jlebon jlebon force-pushed the vlc_disk branch 3 times, most recently from a62c143 to 2e9ed64 Compare January 15, 2024 20:59
@mike-nguyen @jlebon
kola/tests: add /var/lib/containers to separate disk test
835b0be 
Customers have requested the ability to use a separate disk for
/var/lib/containers as a day two operation.  This is a sanity
test that makes sure this can be done with systemd units as
described in the knowlege base article [0].

[0] https://access.redhat.com/solutions/4952011
@jlebon
Copy link
Member

jlebon commented Jan 16, 2024

Neat, Prow CI uncovered a bug in Ignition: coreos/ignition#1789

Anyway, it's trivial to work around it so let's do that instead.

@jlebon jlebon merged commit e9b7278 into coreos:main Jan 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters cgwalters left review comments

@arithx arithx arithx approved these changes

@jlebon jlebon jlebon approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mike-nguyen @arithx @openshift-ci-robot @jlebon @cgwalters