stages/files: filter out non-existent paths before relabeling #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the release note item more similar to the language used in our release notes.
The code that handles systemd unit enablement via preset will no op if disabling a systemd unit that is already disabled, which means that we wouldn't create a preset file in that case. But we did mark the preset file as needing relabeling unconditionally. Since `setfiles` errors out if you pass it a path that doesn't exist, this would break boot. Fix this by filtering out all entries that don't exist right before we call `setfiles`. Another approach would've been to only mark the file for relabeling if we actually did write the file, but this is more complex than it seems because the relabeling logic needs to know what is the first component in the path that had to be created. So we'd need logic both before and after file creation. This isn't user-reported; we hit this in a CI test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that handles systemd unit enablement via preset will no op if
disabling a systemd unit that is already disabled, which means that we
wouldn't create a preset file in that case. But we did mark the preset
file as needing relabeling unconditionally. Since
setfileserrors outif you pass it a path that doesn't exist, this would break boot.
Fix this by filtering out all entries that don't exist right before we
call
setfiles. Another approach would've been to only mark the filefor relabeling if we actually did write the file, but this is more
complex than it seems because the relabeling logic needs to know what
is the first component in the path that had to be created. So we'd need
logic both before and after file creation.
This isn't user-reported; we hit this in a CI test.