create_disk: add support for bootfs_metadata_csum_seed image.yaml knob #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustymabe
added a commit
to dustymabe/fedora-coreos-config
that referenced
this pull request
Jun 15, 2021
This will tell COSA to set the metadata_csum_seed filesystem feature for the boot filesystem. This helps us not have to run a filesystem check before running tune2fs to randomize the filesystem UUID on first boot. See coreos/fedora-coreos-tracker#735 for more context. Depends on coreos/coreos-assembler#2228
darkmuggle
approved these changes
Jun 15, 2021
dustymabe
force-pushed
the
dusty-bootfs-csum-seed-imageyaml-knob
branch
from
24bc21b to
c09cb44
Compare
Add support for a bootfs_metadata_csum_seed image.yaml knob that tells us to enable the metadata_csum_seed ext4 filesystem feature. This is gated behind an image.yaml knob because support for this feature flag was only recently added to grub. https://lists.gnu.org/archive/html/grub-devel/2021-06/msg00031.html This helps us not have to run a filesystem check before running tune2fs to randomize the filesystem UUID on first boot. See coreos/fedora-coreos-tracker#735 for more context. The knob in image.yaml will look like: ``` bootfs_metadata_csum_seed: true ```
dustymabe
force-pushed
the
dusty-bootfs-csum-seed-imageyaml-knob
branch
from
c09cb44 to
d734007
Compare
jlebon
reviewed
Jun 16, 2021
| # flag was only recently added to grub. | ||
| # https://lists.gnu.org/archive/html/grub-devel/2021-06/msg00031.html | ||
| if [ "${bootfs_metadata_csum_seed}" == "true" ]; then | ||
| bootargs="-O metadata_csum_seed" |
There was a problem hiding this comment.
I think we need some spacing here or below in the ext4verity path to separate option flags.
There was a problem hiding this comment.
yeah, the local version of my patch (on my aarch64 machine) had that, but I missed it when I made the changes on my desktop and pushed them up. fix in #2230
dustymabe
added a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Jul 1, 2021
This will tell COSA to set the metadata_csum_seed filesystem feature for the boot filesystem. This helps us not have to run a filesystem check before running tune2fs to randomize the filesystem UUID on first boot. See coreos/fedora-coreos-tracker#735 for more context. Depends on coreos/coreos-assembler#2228
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
This will tell COSA to set the metadata_csum_seed filesystem feature for the boot filesystem. This helps us not have to run a filesystem check before running tune2fs to randomize the filesystem UUID on first boot. See coreos/fedora-coreos-tracker#735 for more context. Depends on coreos/coreos-assembler#2228
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
This will tell COSA to set the metadata_csum_seed filesystem feature for the boot filesystem. This helps us not have to run a filesystem check before running tune2fs to randomize the filesystem UUID on first boot. See coreos/fedora-coreos-tracker#735 for more context. Depends on coreos/coreos-assembler#2228
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for a bootfs_metadata_csum_seed image.yaml knob that tells
us to enable the metadata_csum_seed ext4 filesystem feature.
This is gated behind an image.yaml knob because support for this feature
flag was only recently added to grub.
https://lists.gnu.org/archive/html/grub-devel/2021-06/msg00031.html
This helps us not have to run a filesystem check before running tune2fs
to randomize the filesystem UUID on first boot. See
coreos/fedora-coreos-tracker#735 for more
context.
The knob in image.yaml will look like: