-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image-base.yaml: set bootfs_metadata_csum_seed to true #1063
image-base.yaml: set bootfs_metadata_csum_seed to true #1063
Conversation
Opening this PR now so I don't forget about it later. We should be able to merge this once the new grub2 package has landed but let's hold even longer (for a release or two) to give the fallback codepath (in #1054) some time to get exercised since that the path RHCOS will take for a while. |
This will tell COSA to set the metadata_csum_seed filesystem feature for the boot filesystem. This helps us not have to run a filesystem check before running tune2fs to randomize the filesystem UUID on first boot. See coreos/fedora-coreos-tracker#735 for more context. Depends on coreos/coreos-assembler#2228
51aab4a
to
7ec9d4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK to me, but I'd personally still prefer the "set the system clock if older than the filesystem on boot". OTOH that's an uglier patch, and this filesystem flag sounds useful.
Now that coreos/fedora-coreos-config#1063 has landed we need the new grub2 so that our image builds don't fail.
Now that coreos/fedora-coreos-config#1063 has landed we need the new grub2 so that our image builds don't fail.
Now that coreos/fedora-coreos-config#1063 has landed we need the new grub2 so that our image builds don't fail.
Now that coreos/fedora-coreos-config#1063 has landed we need the new grub2 so that our image builds don't fail.
OCPBUGS-3958: [release-4.12] Use kernel-rt from ose repo
This will tell COSA to set the metadata_csum_seed filesystem feature
for the boot filesystem. This helps us not have to run a filesystem
check before running tune2fs to randomize the filesystem UUID on first boot. See
coreos/fedora-coreos-tracker#735 for more context.
Depends on coreos/coreos-assembler#2228