Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image-base.yaml: set bootfs_metadata_csum_seed to true #1063

Merged

Conversation

dustymabe
Copy link
Member

@dustymabe dustymabe commented Jun 15, 2021

This will tell COSA to set the metadata_csum_seed filesystem feature
for the boot filesystem. This helps us not have to run a filesystem
check before running tune2fs to randomize the filesystem UUID on first boot. See
coreos/fedora-coreos-tracker#735 for more context.

Depends on coreos/coreos-assembler#2228

@dustymabe
Copy link
Member Author

Opening this PR now so I don't forget about it later.

We should be able to merge this once the new grub2 package has landed but let's hold even longer (for a release or two) to give the fallback codepath (in #1054) some time to get exercised since that the path RHCOS will take for a while.

This will tell COSA to set the metadata_csum_seed filesystem feature
for the boot filesystem. This helps us not have to run a filesystem
check before running tune2fs to randomize the filesystem UUID on first boot. See
coreos/fedora-coreos-tracker#735 for more context.

Depends on coreos/coreos-assembler#2228
@dustymabe dustymabe force-pushed the dusty-bootfs-metadata-csum-seed branch from 51aab4a to 7ec9d4f Compare June 15, 2021 21:22
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK to me, but I'd personally still prefer the "set the system clock if older than the filesystem on boot". OTOH that's an uglier patch, and this filesystem flag sounds useful.

@dustymabe dustymabe marked this pull request as ready for review July 1, 2021 18:56
@dustymabe dustymabe merged commit 4e335e4 into coreos:testing-devel Jul 1, 2021
@dustymabe dustymabe deleted the dusty-bootfs-metadata-csum-seed branch July 1, 2021 18:56
dustymabe added a commit to dustymabe/coreos-assembler that referenced this pull request Jul 1, 2021
Now that coreos/fedora-coreos-config#1063
has landed we need the new grub2 so that our image builds don't fail.
cgwalters pushed a commit to coreos/coreos-assembler that referenced this pull request Jul 1, 2021
Now that coreos/fedora-coreos-config#1063
has landed we need the new grub2 so that our image builds don't fail.
saqibali-2k pushed a commit to saqibali-2k/coreos-assembler that referenced this pull request Jul 6, 2021
Now that coreos/fedora-coreos-config#1063
has landed we need the new grub2 so that our image builds don't fail.
ravanelli pushed a commit to ravanelli/coreos-assembler that referenced this pull request Aug 25, 2021
Now that coreos/fedora-coreos-config#1063
has landed we need the new grub2 so that our image builds don't fail.
c4rt0 pushed a commit to c4rt0/fedora-coreos-config that referenced this pull request Mar 27, 2023
OCPBUGS-3958: [release-4.12] Use kernel-rt from ose repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants