Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VirtualBox OVA image #2489

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Add VirtualBox OVA image #2489

merged 1 commit into from
Apr 8, 2022

Conversation

bgilbert
Copy link
Contributor

@bgilbert bgilbert commented Oct 9, 2021

@openshift-ci
Copy link

openshift-ci bot commented Oct 9, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@prestist prestist marked this pull request as ready for review March 24, 2022 18:08
@prestist prestist changed the title WIP: Add VirtualBox OVA image Add VirtualBox OVA image Mar 24, 2022
@prestist
Copy link
Contributor

Ready for review

@dustymabe
Copy link
Member

trivial LGTM

@dustymabe
Copy link
Member

cc @bgilbert for review.

Copy link
Contributor Author

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments. I'd also like to go through the hardware settings in VBox and see if they look reasonable. Have you done that also?

src/virtualbox-template.xml Show resolved Hide resolved
src/virtualbox-template.xml Outdated Show resolved Hide resolved
src/virtualbox-template.xml Show resolved Hide resolved
src/virtualbox-template.xml Outdated Show resolved Hide resolved
src/virtualbox-template.xml Show resolved Hide resolved
src/virtualbox-template.xml Outdated Show resolved Hide resolved
@bgilbert
Copy link
Contributor Author

This can probably be squashed down to one commit.

@bgilbert
Copy link
Contributor Author

Looked through the resulting VM settings. We should enable EFI and maybe nested virtualization. Networking still seems to be NAT. Also, the storage controller is LSI Logic, which is an old favorite for virtualization but is a bit obscure. AHCI (Serial ATA) is supported, so maybe we should switch to that?

@prestist
Copy link
Contributor

prestist commented Mar 25, 2022

Networking still seems to be NAT

@bgilbert Are the settings possibly being lost during import? There is a section called "MAC Address Policy" that seems to imply that its overriding with NAT settings.

@bgilbert
Copy link
Contributor Author

Yeah, it's possible. If we can't find a way around that, we should document the fact and how to switch to bridging.

Copy link
Contributor Author

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits and one thing I missed earlier. Also, please squash down to one commit.

src/virtualbox-template.xml Outdated Show resolved Hide resolved
src/virtualbox-template.xml Outdated Show resolved Hide resolved
src/virtualbox-template.xml Show resolved Hide resolved
@prestist
Copy link
Contributor

prestist commented Apr 6, 2022

@bgilbert This might be ready now. Go ahead and take a look!

src/virtualbox-template.xml Outdated Show resolved Hide resolved
src/virtualbox-template.xml Outdated Show resolved Hide resolved
src/virtualbox-template.xml Outdated Show resolved Hide resolved
src/virtualbox-template.xml Show resolved Hide resolved
@bgilbert
Copy link
Contributor Author

bgilbert commented Apr 8, 2022

I think it's okay to fix the remaining issues as a followup if it helps for FCOS freeze. For that purpose, tagging @dustymabe for review, since I can't approve my own PR.

@bgilbert bgilbert requested a review from dustymabe April 8, 2022 01:06
dustymabe
dustymabe previously approved these changes Apr 8, 2022
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prestist
Copy link
Contributor

prestist commented Apr 8, 2022

@dustymabe Hey sorry, just pushed a quick fix around the ACHI port count. Could I get your re-approval?

@bgilbert
Copy link
Contributor Author

bgilbert commented Apr 8, 2022

Tested and LGTM!

@prestist
Copy link
Contributor

prestist commented Apr 8, 2022

/retest-required

@bgilbert
Copy link
Contributor Author

bgilbert commented Apr 8, 2022

/retest

@bgilbert
Copy link
Contributor Author

bgilbert commented Apr 8, 2022

The rhcos job is timing out fetching repo metadata for rhel-8-server-ose. That job previously passed on this PR, and the only subsequent changes have been to the OVF XML, which the job doesn't test.

/override ci/prow/rhcos

@openshift-ci
Copy link

openshift-ci bot commented Apr 8, 2022

@bgilbert: Overrode contexts on behalf of bgilbert: ci/prow/rhcos

In response to this:

The rhcos job is timing out fetching repo metadata for rhel-8-server-ose. That job previously passed on this PR, and the only subsequent changes have been to the OVF XML, which the job doesn't test.

/override ci/prow/rhcos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@prestist prestist enabled auto-merge (rebase) April 8, 2022 15:28
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants