Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HyperV support #1421

Closed
29 tasks
bgilbert opened this issue Feb 15, 2023 · 3 comments
Closed
29 tasks

Implement HyperV support #1421

bgilbert opened this issue Feb 15, 2023 · 3 comments
Assignees

Comments

@bgilbert
Copy link
Contributor

Implementing a new supported platform

During Development

Create PR's addressing the following:

At Release

  1. Merge metadata changes:

    • stream-metadata-go
    • stream-metadata-rust
    • fedora-coreos-tracker
    • fedora website
    • fedora-coreos-browser
  2. Create and push signed tags with appropriate versions

    # Ensure gpg key for signing in github settings that is associated to redhat email.
    # Verify you are on the upstream repo's main branch.
    
    git status
    
    RELEASE_VER=vx.y.z
    # Replace 'x.y.z' with the appropriate numbers.
    
    git tag -s ${RELEASE_VER}
    # Give appropriate detail to tag, check previous tags with 'git show ${RELEASE_VER}'
    
    git push git@github.com:coreos/targeted-repo.git ${RELEASE_VER}
    # Navigate to the targeted-repo's tag section to ensure a valid signed tag is listed.
    # e.g. https://github.com/...repo/tags 
    
    1. Tag stream-metadata-go following the above steps. After tagging, ensure that dependabot has picked up latest version, and merged it into fedora-coreos-stream-generator && coreos-assembler.

    2. Tag fedora-coreos-stream-generator following the above steps.

  3. Merge the following changes:

    • coreos-assembler
  4. Wait for updates made to coreos-assembler to be propagated to latest container

    • Download latest version of coreos-assembler container. Verify platform support functionality.
  5. Merge changes for:

    • Build pipeline
  6. Wait for new images to reach stable then merge documentation.

    • fedora-coreos-docs merged
baude added a commit to baude/stream-metadata-go that referenced this issue Feb 15, 2023
Following new platform support checklist for Hyperv

coreos/fedora-coreos-tracker#1421
@baude
Copy link
Contributor

baude commented Feb 15, 2023

btw, can assign to me

baude added a commit to baude/coreos-assembler that referenced this issue Feb 16, 2023
buildextend --compress supports gzip as an alternate compression over
xz using a key called "gzip" where the value is a bool.  This is now
refactored to a key called "compression" with a value of "gzip", "skip",
or "zip" (see below).  The "skip-compression" key is no longer
applicable.

HyperV images which are used on Windows need to be compressed with zip
because xz and gzip are not supported natively.  Added zip support to
buildextend and set the hyperv platform compression to "zip".

Supports:
  * coreos/fedora-coreos-tracker#1411
  * coreos/fedora-coreos-tracker#1421

Signed-off-by: Brent Baude <bbaude@redhat.com>
baude added a commit to baude/fedora-coreos-browser that referenced this issue Feb 16, 2023
Supports:
  * coreos/fedora-coreos-tracker#1411
  * coreos/fedora-coreos-tracker#1421

Signed-off-by: Brent Baude <bbaude@redhat.com>
@bgilbert
Copy link
Contributor Author

We should update the checklist template with a new example PR for fedora-coreos-pipeline.

baude added a commit to baude/fedora-coreos-pipeline that referenced this issue Feb 16, 2023
@baude
Copy link
Contributor

baude commented Feb 17, 2023

please close in favor of #1424

@jlebon jlebon closed this as not planned Won't fix, can't repro, duplicate, stale Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants