Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IBMCloud/PowerVS images #16

Merged
merged 4 commits into from
Nov 4, 2021

Conversation

Prashanth684
Copy link
Contributor

Adding support for IBMCloud/PowerVS objects to be added to the stream.

similar to coreos/stream-metadata-go#35

@bgilbert
Copy link
Contributor

I know we haven't generalized the AWS image struct in the Rust bindings, but we should probably avoid compounding the mistake, and go with ReplicatedObject/RegionObject again here.

@Prashanth684
Copy link
Contributor Author

I know we haven't generalized the AWS image struct in the Rust bindings, but we should probably avoid compounding the mistake, and go with ReplicatedObject/RegionObject again here.

yes that makes sense. done.

src/lib.rs Show resolved Hide resolved
Adding support for IBMCloud/PowerVS objects to be added to the stream.

similar to coreos/stream-metadata-go#35
Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just some wording suggestions.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
Prashanth684 and others added 3 commits November 4, 2021 14:35
Co-authored-by: Benjamin Gilbert <bgilbert@backtick.net>
Co-authored-by: Benjamin Gilbert <bgilbert@backtick.net>
Co-authored-by: Benjamin Gilbert <bgilbert@backtick.net>
Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants