-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for IBMCloud/PowerVS images #16
Conversation
I know we haven't generalized the AWS image struct in the Rust bindings, but we should probably avoid compounding the mistake, and go with |
yes that makes sense. done. |
Adding support for IBMCloud/PowerVS objects to be added to the stream. similar to coreos/stream-metadata-go#35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; just some wording suggestions.
Co-authored-by: Benjamin Gilbert <bgilbert@backtick.net>
Co-authored-by: Benjamin Gilbert <bgilbert@backtick.net>
Co-authored-by: Benjamin Gilbert <bgilbert@backtick.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Adding support for IBMCloud/PowerVS objects to be added to the stream.
similar to coreos/stream-metadata-go#35