build: Add fedora-coreos.stream to image labels
#3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
added a commit
to cgwalters/ostree-rs-ext
that referenced
this pull request
Nov 21, 2022
This is to aid coreos/coreos-assembler#3214 which is trying to inject the metadata key `fedora-coreos.stream` into the container image. However, this value will only be present in Fedora derivatives, and not RHEL/CentOS. Add support for copying a key only if present, instead of erroring if it's missing.
cgwalters
added a commit
to cgwalters/ostree-rs-ext
that referenced
this pull request
Nov 21, 2022
This is to aid coreos/coreos-assembler#3214 which is trying to inject the metadata key `fedora-coreos.stream` into the container image. However, this value will only be present in Fedora derivatives, and not RHEL/CentOS. Add support for copying a key only if present, instead of erroring if it's missing.
|
OK, did ostreedev/ostree-rs-ext#415 to help this. |
jlebon
previously approved these changes
Nov 22, 2022
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Dec 14, 2022
I meant to do this after landing the ostree-ext updates in order to push forward coreos/coreos-assembler#3214
We aren't going to use this.
From discussion in coreos/zincati#878 related to coreos/fedora-coreos-tracker#1263
cgwalters
force-pushed
the
propagate-stream
branch
from
8bad257
to
c0dc9d0
Compare
|
OK, a month later now, I think we can depend on the newer rpm-ostree. |
jlebon
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build: Drop reference to
ostree container encapsulateWe aren't going to use this.
build: Add
fedora-coreos.streamto image labelsFrom discussion in coreos/zincati#878
related to coreos/fedora-coreos-tracker#1263