Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container: Add support for copying optionally-present keys #415

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

cgwalters
Copy link
Member

This is to aid coreos/coreos-assembler#3214 which is trying to inject the metadata key fedora-coreos.stream into the container image. However, this value will only be present in Fedora derivatives, and not RHEL/CentOS.

Add support for copying a key only if present, instead of erroring if it's missing.

This is to aid coreos/coreos-assembler#3214
which is trying to inject the metadata key `fedora-coreos.stream`
into the container image.  However, this value will only be
present in Fedora derivatives, and not RHEL/CentOS.

Add support for copying a key only if present, instead of
erroring if it's missing.
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me!

@cgwalters
Copy link
Member Author

Inbound fix for the IMA tests in #419

@cgwalters cgwalters merged commit fa59f81 into ostreedev:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants