-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mantle: stabilize Ignition 3.4.0 spec #3387
Conversation
The Butane bump is needed for compatibility with the Ignition 3.4.0 spec stabilization. It does not include the corresponding Butane spec stabilizations, which haven't landed yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't fully follow the ratcheting steps involved across all these repos, but seems sane to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superficial LGTM
We're going to need a second ratchet between cosa and fedora-coreos-config when the Butane stabilizations land in cosa and cause the Butane experimental specs in f-c-c to stop being accepted. The idea here is to allow unsnoozing the tests until then, and reduce the time pressure to stabilize Butane. |
RHCOS CI is failing because this is still testing against RHCOS 4.13-8.6, which doesn't have Ignition 2.15.0. Should we fix that first, or should I merge over red? |
/override ci/prow/rhcos |
@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/rhcos In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Filed #3388 to track bumping the RHCOS job to RHEL 9.2. |
The corresponding Butane spec stabilizations haven't happened yet (tracked in coreos/butane#434) but coreos/butane#435 switched the experimental Butane specs to emit Ignition spec 3.4.0 instead of 3.4.0-experimental. That's sufficient to fix the failures in kola external tests that use the Butane experimental specs, and to give us source-compatible versions of Ignition and Butane. Bump Ignition to 2.15.0 and Butane to Git main.
Fixes openshift/os#1187.